Add Signal interfaces and denormalizers for Webauthn serialization

Introduced `Signal` interfaces and their implementations (`AllAcceptedCredentials`, `CurrentUserDetails`, `UnknownCredential`) along with corresponding denormalizers. Updated the serializer factory and added test cases to ensure proper signal handling and serialization. Refactored constructors for cleaner code consistency.

Author: Spomky

src/webauthn/src/AttestationStatement/TPMAttestationStatementSupport.php

@@ -41,9 +41,8 @@ final class TPMAttestationStatementSupport implements AttestationStatementSuppor
 
     private readonly ClockInterface $clock;
 
-    public function __construct(
-        null|ClockInterface $clock = null
-    ) {
+    public function __construct(null|ClockInterface $clock = null)
+    {
         $this->clock = $clock ?? new NativeClock();
         $this->dispatcher = new NullEventDispatcher();
     }

src/webauthn/src/CeremonyStep/CheckClientDataCollectorType.php

@@ -16,9 +16,8 @@
 {
     private ClientDataCollectorManager $clientDataCollectorManager;
 
-    public function __construct(
-        null|ClientDataCollectorManager $clientDataCollectorManager = null,
-    ) {
+    public function __construct(null|ClientDataCollectorManager $clientDataCollectorManager = null)
+    {
         $this->clientDataCollectorManager = $clientDataCollectorManager ?? new ClientDataCollectorManager([
             new WebauthnAuthenticationCollector(),
         ]);

src/webauthn/src/CeremonyStep/CheckSignature.php

@@ -26,9 +26,8 @@
 {
     private Manager $algorithmManager;
 
-    public function __construct(
-        null|Manager $algorithmManager = null,
-    ) {
+    public function __construct(null|Manager $algorithmManager = null)
+    {
         $this->algorithmManager = $algorithmManager ?? Manager::create()->add(ES256::create(), RS256::create());
     }
 

src/webauthn/src/Denormalizer/SignalAllAcceptedCredentialsDenormalizer.php

@@ -0,0 +1,60 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Webauthn\Denormalizer;
+
+use Symfony\Component\Serializer\Normalizer\NormalizerAwareInterface;
+use Symfony\Component\Serializer\Normalizer\NormalizerAwareTrait;
+use Symfony\Component\Serializer\Normalizer\NormalizerInterface;
+use Webauthn\PublicKeyCredentialDescriptor;
+use Webauthn\Signal\AllAcceptedCredentials;
+use function assert;
+
+class SignalAllAcceptedCredentialsDenormalizer implements NormalizerInterface, NormalizerAwareInterface
+{
+    use NormalizerAwareTrait;
+
+    /**
+     * @return array<class-string, bool>
+     */
+    public function getSupportedTypes(?string $format): array
+    {
+        return [
+            AllAcceptedCredentials::class => true,
+        ];
+    }
+
+    /**
+     * @return array<string, mixed>
+     */
+    public function normalize(mixed $data, ?string $format = null, array $context = []): array
+    {
+        assert($data instanceof AllAcceptedCredentials);
+
+        $normalized_rp = $this->normalizer->normalize($data->rp, $format, $context);
+
+        $normalized_user = $this->normalizer->normalize($data->user, $format, $context);
+
+        $normalized_credentials = array_map(function (PublicKeyCredentialDescriptor $credential) use (
+            $format,
+            $context
+        ) {
+            return $this->normalizer->normalize($credential, $format, $context);
+        }, $data->allAcceptedCredentials);
+
+        return [
+            'rpId' => $normalized_rp['id'],
+            'userId' => $normalized_user['id'],
+            'allAcceptedCredentialIds' => array_map(
+                fn (array $credential): string => $credential['id'],
+                $normalized_credentials
+            ),
+        ];
+    }
+
+    public function supportsNormalization(mixed $data, ?string $format = null, array $context = []): bool
+    {
+        return $data instanceof AllAcceptedCredentials;
+    }
+}

src/webauthn/src/Denormalizer/SignalCurrentUserDetailsDenormalizer.php

@@ -0,0 +1,50 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Webauthn\Denormalizer;
+
+use Symfony\Component\Serializer\Normalizer\NormalizerAwareInterface;
+use Symfony\Component\Serializer\Normalizer\NormalizerAwareTrait;
+use Symfony\Component\Serializer\Normalizer\NormalizerInterface;
+use Webauthn\Signal\CurrentUserDetails;
+use function assert;
+
+class SignalCurrentUserDetailsDenormalizer implements NormalizerInterface, NormalizerAwareInterface
+{
+    use NormalizerAwareTrait;
+
+    /**
+     * @return array<class-string, bool>
+     */
+    public function getSupportedTypes(?string $format): array
+    {
+        return [
+            CurrentUserDetails::class => true,
+        ];
+    }
+
+    /**
+     * @return array<string, mixed>
+     */
+    public function normalize(mixed $data, ?string $format = null, array $context = []): array
+    {
+        assert($data instanceof CurrentUserDetails);
+
+        $normalized_rp = $this->normalizer->normalize($data->rp, $format, $context);
+
+        $normalized_user = $this->normalizer->normalize($data->user, $format, $context);
+
+        return [
+            'rpId' => $normalized_rp['id'],
+            'userId' => $normalized_user['id'],
+            'name' => $normalized_user['name'],
+            'displayName' => $normalized_user['displayName'],
+        ];
+    }
+
+    public function supportsNormalization(mixed $data, ?string $format = null, array $context = []): bool
+    {
+        return $data instanceof CurrentUserDetails;
+    }
+}

src/webauthn/src/Denormalizer/SignalUnknownCredentialDenormalizer.php

@@ -0,0 +1,48 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Webauthn\Denormalizer;
+
+use Symfony\Component\Serializer\Normalizer\NormalizerAwareInterface;
+use Symfony\Component\Serializer\Normalizer\NormalizerAwareTrait;
+use Symfony\Component\Serializer\Normalizer\NormalizerInterface;
+use Webauthn\Signal\UnknownCredential;
+use function assert;
+
+class SignalUnknownCredentialDenormalizer implements NormalizerInterface, NormalizerAwareInterface
+{
+    use NormalizerAwareTrait;
+
+    /**
+     * @return array<class-string, bool>
+     */
+    public function getSupportedTypes(?string $format): array
+    {
+        return [
+            UnknownCredential::class => true,
+        ];
+    }
+
+    /**
+     * @return array<string, mixed>
+     */
+    public function normalize(mixed $data, ?string $format = null, array $context = []): array
+    {
+        assert($data instanceof UnknownCredential);
+
+        $normalized_rp = $this->normalizer->normalize($data->rp, $format, $context);
+
+        $normalized_credential = $this->normalizer->normalize($data->credential, $format, $context);
+
+        return [
+            'rpId' => $normalized_rp['id'],
+            'credentialId' => $normalized_credential['id'],
+        ];
+    }
+
+    public function supportsNormalization(mixed $data, ?string $format = null, array $context = []): bool
+    {
+        return $data instanceof UnknownCredential;
+    }
+}

src/webauthn/src/Denormalizer/WebauthnSerializerFactory.php

@@ -60,6 +60,9 @@ public function create(): SerializerInterface
             new PublicKeyCredentialOptionsDenormalizer(),
             new PublicKeyCredentialSourceDenormalizer(),
             new PublicKeyCredentialUserEntityDenormalizer(),
+            new SignalAllAcceptedCredentialsDenormalizer(),
+            new SignalCurrentUserDetailsDenormalizer(),
+            new SignalUnknownCredentialDenormalizer(),
             new TrustPathDenormalizer(),
             new UidNormalizer(),
             new ArrayDenormalizer(),

src/webauthn/src/MetadataService/Service/JsonMetadataService.php

@@ -30,10 +30,8 @@ final class JsonMetadataService implements MetadataService, CanDispatchEvents
     /**
      * @param string[] $statements
      */
-    public function __construct(
-        array $statements,
-        ?SerializerInterface $serializer = null,
-    ) {
+    public function __construct(array $statements, ?SerializerInterface $serializer = null)
+    {
         $this->dispatcher = new NullEventDispatcher();
         $this->serializer = $serializer ?? (new WebauthnSerializerFactory(
             AttestationStatementSupportManager::create()

src/webauthn/src/Signal/AllAcceptedCredentials.php

@@ -0,0 +1,22 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Webauthn\Signal;
+
+use Webauthn\PublicKeyCredentialDescriptor;
+use Webauthn\PublicKeyCredentialRpEntity;
+use Webauthn\PublicKeyCredentialUserEntity;
+
+readonly class AllAcceptedCredentials implements Signal
+{
+    /**
+     * @param PublicKeyCredentialDescriptor[] $allAcceptedCredentials
+     */
+    public function __construct(
+        public PublicKeyCredentialRpEntity $rp,
+        public PublicKeyCredentialUserEntity $user,
+        public array $allAcceptedCredentials,
+    ) {
+    }
+}

src/webauthn/src/Signal/CurrentUserDetails.php

@@ -0,0 +1,17 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Webauthn\Signal;
+
+use Webauthn\PublicKeyCredentialRpEntity;
+use Webauthn\PublicKeyCredentialUserEntity;
+
+readonly class CurrentUserDetails implements Signal
+{
+    public function __construct(
+        public PublicKeyCredentialRpEntity $rp,
+        public PublicKeyCredentialUserEntity $user,
+    ) {
+    }
+}