Skip to content

Conversation

@ethanshar
Copy link
Collaborator

Description

In order to share docs between compound components of the same parent I copy the docs entry from the parent to children
for example components like (TabController and its children TabController.TabBar, TabController.TabPage, etc...)

Changelog

Share docs between compound components

Additional info

@Inbal-Tish
Copy link
Collaborator

@ethanshar I'm not sure I understand this PR... How will the TabController docs will look like if we want to add docs to both TabBar (exists) and TabPage components?

@ethanshar
Copy link
Collaborator Author

@ethanshar I'm not sure I understand this PR... How will the TabController docs will look like if we want to add docs to both TabBar (exists) and TabPage components?

I discussed with Yulia, she also preferred to remove 🙄 so I removed

@ethanshar ethanshar requested a review from Inbal-Tish December 4, 2024 11:55
@ethanshar ethanshar assigned Inbal-Tish and unassigned ethanshar Dec 4, 2024
@Inbal-Tish
Copy link
Collaborator

@ethanshar I'm not sure I understand this PR... How will the TabController docs will look like if we want to add docs to both TabBar (exists) and TabPage components?

I discussed with Yulia, she also preferred to remove 🙄 so I removed

Then why you did remove the docs for the TabBar after moving them to the TabController? Now there is a duplication...

@Inbal-Tish Inbal-Tish assigned ethanshar and unassigned Inbal-Tish Dec 4, 2024
@Inbal-Tish Inbal-Tish enabled auto-merge (squash) December 4, 2024 13:46
@Inbal-Tish Inbal-Tish merged commit b29302e into master Dec 4, 2024
1 check passed
@Inbal-Tish Inbal-Tish deleted the infra/compound_components_docs branch December 4, 2024 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants