Skip to content
This repository was archived by the owner on Feb 14, 2025. It is now read-only.

Commit 90c9809

Browse files
committed
Build tweaks for ARM64.
1 parent 2785c70 commit 90c9809

File tree

5 files changed

+11
-12
lines changed

5 files changed

+11
-12
lines changed

history/5558.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
* BobArnson: WIXFEATURE:5558 - Implement ARM64 support in core toolset

src/Setup/NativeSdkMsi/Libs.wxs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@
4545

4646
<Fragment>
4747
<ComponentGroup Id="LibARM64Components" Directory="SdkARM64LibFolder">
48-
<?if $(var.BuildARM64) = true ?>
48+
<?if $(var.BuildARM64) = true and $(var.VisualStudioTargetVersion) = 2017 ?>
4949
<Component>
5050
<File Id="dutil_arm64.lib" Source="!(bindpath.arm64)\$(var.VisualStudioTargetVersion)\dutil.lib"/>
5151
</Component>

src/libs/libs.proj

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,9 +10,6 @@
1010
<ProjectReference Include="libs_multitarget.proj">
1111
<Properties>Platform=x64</Properties>
1212
</ProjectReference>
13-
<ProjectReference Include="libs_multitarget.proj" Condition="$(BuildARM)">
14-
<Properties>Platform=arm</Properties>
15-
</ProjectReference>
1613
<ProjectReference Include="libs_multitarget.proj" Condition="$(BuildARM64)">
1714
<Properties>Platform=arm64</Properties>
1815
</ProjectReference>

src/libs/libs_multitarget.proj

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33

44

55
<Project DefaultTargets="Build" xmlns="http://schemas.microsoft.com/developer/msbuild/2003" ToolsVersion="4.0">
6-
<ItemGroup Condition=" $(VS2010Available) ">
6+
<ItemGroup Condition=" $(VS2010Available) AND '$(Platform)'!='arm64' ">
77
<ProjectReference Include="dutil\dutil.vcxproj">
88
<Properties>PlatformToolset=v100</Properties>
99
</ProjectReference>
@@ -18,7 +18,7 @@
1818
</ProjectReference>
1919
</ItemGroup>
2020

21-
<ItemGroup Condition=" $(VS2012Available) ">
21+
<ItemGroup Condition=" $(VS2012Available) AND '$(Platform)'!='arm64' ">
2222
<ProjectReference Include="dutil\dutil.vcxproj">
2323
<Properties>PlatformToolset=v110_xp</Properties>
2424
</ProjectReference>
@@ -33,7 +33,7 @@
3333
</ProjectReference>
3434
</ItemGroup>
3535

36-
<ItemGroup Condition=" $(VS2013Available) and !$(StaticAnalysisEnabled) ">
36+
<ItemGroup Condition=" $(VS2013Available) and !$(StaticAnalysisEnabled) AND '$(Platform)'!='arm64' ">
3737
<ProjectReference Include="dutil\dutil.vcxproj">
3838
<Properties>PlatformToolset=v120_xp</Properties>
3939
</ProjectReference>
@@ -48,7 +48,7 @@
4848
</ProjectReference>
4949
</ItemGroup>
5050

51-
<ItemGroup Condition=" $(VS2013Available) and $(StaticAnalysisEnabled) ">
51+
<ItemGroup Condition=" $(VS2013Available) and $(StaticAnalysisEnabled) AND '$(Platform)'!='arm64' ">
5252
<ProjectReference Include="dutil\dutil.vcxproj">
5353
<Properties>PlatformToolset=v120</Properties>
5454
</ProjectReference>
@@ -63,7 +63,7 @@
6363
</ProjectReference>
6464
</ItemGroup>
6565

66-
<ItemGroup Condition=" $(VS2015Available) and !$(StaticAnalysisEnabled) ">
66+
<ItemGroup Condition=" $(VS2015Available) and !$(StaticAnalysisEnabled) AND '$(Platform)'!='arm64' ">
6767
<ProjectReference Include="dutil\dutil.vcxproj">
6868
<Properties>PlatformToolset=v140_xp</Properties>
6969
</ProjectReference>
@@ -78,7 +78,7 @@
7878
</ProjectReference>
7979
</ItemGroup>
8080

81-
<ItemGroup Condition=" $(VS2015Available) and $(StaticAnalysisEnabled) ">
81+
<ItemGroup Condition=" $(VS2015Available) and $(StaticAnalysisEnabled) AND '$(Platform)'!='arm64' ">
8282
<ProjectReference Include="dutil\dutil.vcxproj">
8383
<Properties>PlatformToolset=v140</Properties>
8484
</ProjectReference>
@@ -100,7 +100,7 @@
100100
<ProjectReference Include="wcautil\wcautil.vcxproj">
101101
<Properties>PlatformToolset=v141_xp</Properties>
102102
</ProjectReference>
103-
<ProjectReference Include="balutil\balutil.vcxproj" Condition=" '$(Platform)'=='x86' OR '$(Platform)'=='arm' ">
103+
<ProjectReference Include="balutil\balutil.vcxproj" Condition=" '$(Platform)'=='x86' ">
104104
<Properties>PlatformToolset=v141_xp</Properties>
105105
</ProjectReference>
106106
<ProjectReference Include="deputil\deputil.vcxproj">
@@ -115,7 +115,7 @@
115115
<ProjectReference Include="wcautil\wcautil.vcxproj">
116116
<Properties>PlatformToolset=v141</Properties>
117117
</ProjectReference>
118-
<ProjectReference Include="balutil\balutil.vcxproj" Condition=" '$(Platform)'=='x86' OR '$(Platform)'=='arm' ">
118+
<ProjectReference Include="balutil\balutil.vcxproj" Condition=" '$(Platform)'=='arm' ">
119119
<Properties>PlatformToolset=v141</Properties>
120120
</ProjectReference>
121121
<ProjectReference Include="deputil\deputil.vcxproj">

wix.proj

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@
2020
<ProjectReference Include="src\chm\chm.helpproj" />
2121
<ProjectReference Include="src\setup\setup.proj" />
2222
<ProjectReference Include="test\test.proj" />
23+
<!-- <ProjectReference Include="src\wixarm.proj" Condition=" $(BuildARM) " /> -->
2324
</ItemGroup>
2425

2526
<Import Project="tools\Traversal.targets" />

0 commit comments

Comments
 (0)