-
Notifications
You must be signed in to change notification settings - Fork 3
refactor: Remove remote editor variant #210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c5fc89c to
eacb4e1
Compare
Base automatically changed from
feat/bundled-editor-supports-plugins
to
trunk
November 6, 2025 22:19
eacb4e1 to
6271be8
Compare
The default editor now supports plugins, so the variant is not longer necessary.
With the removal of the remote editor variant, the "bundled" term no longer communicates intent. The utility manages setting up the editor environment with a specific sequence.
This is now handled in the `editor-environment` logic as it depends upon the plugins assets fetching.
6271be8 to
064717a
Compare
30296c2 to
c7dc6eb
Compare
The dynamic Android demo app note regarding whether `make build` or `make dev-server` is powering the editor was not working before.
adalpari
approved these changes
Nov 10, 2025
adalpari
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Remove the remote editor variant as a follow up to #209.
Why?
The remote editor variant is no longer used or necessary.
How?
Remove unused code. Rename and reorganize remaining code for clarity.
Testing Instructions
Smoke test the editor.
Accessibility Testing Instructions
N/A, no user-facing changes.
Screenshots or screencast
N/A, no visual changes.