Dot in ".exe" preg should be escaped.

gitlost · gitlost · commit 314caecc406c · 2017-06-06T17:46:00.000+01:00
diff --git a/lib/cli/Shell.php b/lib/cli/Shell.php
@@ -34,7 +34,7 @@ static public function columns() {
 			if ( function_exists( 'exec' ) ) {
 				if ( self::is_windows() ) {
 					// Cater for shells such as Cygwin and Git bash where `mode CON` returns an incorrect value for columns.
-					if ( ( $shell = getenv( 'SHELL' ) ) && preg_match( '/(?:bash|zsh)(?:.exe)?$/', $shell ) && getenv( 'TERM' ) ) {
+					if ( ( $shell = getenv( 'SHELL' ) ) && preg_match( '/(?:bash|zsh)(?:\.exe)?$/', $shell ) && getenv( 'TERM' ) ) {
 						$columns = (int) exec( 'tput cols' );
 					}
 					if ( ! $columns ) {

Original file line number	Diff line number	Diff line change
`@@ -34,7 +34,7 @@ static public function columns() {`
`34`	`34`	`if ( function_exists( 'exec' ) ) {`
`35`	`35`	`if ( self::is_windows() ) {`
`36`	`36`	// Cater for shells such as Cygwin and Git bash where `mode CON` returns an incorrect value for columns.
`37`		`- if ( ( $shell = getenv( 'SHELL' ) ) && preg_match( '/(?:bash\|zsh)(?:.exe)?$/', $shell ) && getenv( 'TERM' ) ) {`
	`37`	`+ if ( ( $shell = getenv( 'SHELL' ) ) && preg_match( '/(?:bash\|zsh)(?:\.exe)?$/', $shell ) && getenv( 'TERM' ) ) {`
`38`	`38`	`$columns = (int) exec( 'tput cols' );`
`39`	`39`	`}`
`40`	`40`	`if ( ! $columns ) {`