[PHP 8.2] Fix ${var} string interpolation deprecation

Ayesh · Ayesh · commit a3226376006b · 2022-06-19T15:37:20.000+05:30
PHP 8.2 deprecates `"${var}"` string interpolation pattern. This fixes all three of such occurrences in `wp-cli/php-cli-tools` package. - [PHP 8.2: `${var}` string interpolation deprecated](https://php.watch/versions/8.2/${var}-string-interpolation-deprecated) - [RFC](https://wiki.php.net/rfc/deprecate_dollar_brace_string_interpolation)
diff --git a/examples/menu.php b/examples/menu.php
@@ -19,6 +19,6 @@
 		break;
 	}
 
-	include "${choice}.php";
+	include "{$choice}.php";
 	\cli\line();
 }
diff --git a/lib/cli/arguments/HelpScreen.php b/lib/cli/arguments/HelpScreen.php
@@ -91,7 +91,7 @@ private function _renderScreen($options, $max) {
 
 			$pad = str_repeat(' ', $max + 3);
 			while ($desc = array_shift($description)) {
-				$formatted .= "\n${pad}${desc}";
+				$formatted .= "\n{$pad}{$desc}";
 			}
 
 			array_push($help, $formatted);

Original file line number	Diff line number	Diff line change
`@@ -19,6 +19,6 @@`
`19`	`19`	`break;`
`20`	`20`	`}`
`21`	`21`
`22`		`- include "${choice}.php";`
	`22`	`+ include "{$choice}.php";`
`23`	`23`	`\cli\line();`
`24`	`24`	`}`
Original file line number	Diff line number	Diff line change
`@@ -91,7 +91,7 @@ private function _renderScreen($options, $max) {`
`91`	`91`
`92`	`92`	`$pad = str_repeat(' ', $max + 3);`
`93`	`93`	`while ($desc = array_shift($description)) {`
`94`		`- $formatted .= "\n${pad}${desc}";`
	`94`	`+ $formatted .= "\n{$pad}{$desc}";`
`95`	`95`	`}`
`96`	`96`
`97`	`97`	`array_push($help, $formatted);`