Replace exception rethrow with finally

xPaw · web-flow · commit 5ee1614ac6dc · 2018-02-09T23:01:01.000+02:00
Closes #135
diff --git a/src/MinecraftQuery.php b/src/MinecraftQuery.php
@@ -46,15 +46,10 @@ public function Connect( $Ip, $Port = 25565, $Timeout = 3, $ResolveSRV = true )
 
 			$this->GetStatus( $Challenge );
 		}
-		// We catch this because we want to close the socket, not very elegant
-		catch( MinecraftQueryException $e )
+		finally
 		{
 			FClose( $this->Socket );
-
-			throw new MinecraftQueryException( $e->getMessage( ) );
 		}
-
-		FClose( $this->Socket );
 	}
 
 	public function GetInfo( )

Original file line number	Diff line number	Diff line change
`@@ -46,15 +46,10 @@ public function Connect( $Ip, $Port = 25565, $Timeout = 3, $ResolveSRV = true )`
`46`	`46`
`47`	`47`	`$this->GetStatus( $Challenge );`
`48`	`48`	`}`
`49`		`- // We catch this because we want to close the socket, not very elegant`
`50`		`- catch( MinecraftQueryException $e )`
	`49`	`+ finally`
`51`	`50`	`{`
`52`	`51`	`FClose( $this->Socket );`
`53`		`-`
`54`		`- throw new MinecraftQueryException( $e->getMessage( ) );`
`55`	`52`	`}`
`56`		`-`
`57`		`- FClose( $this->Socket );`
`58`	`53`	`}`
`59`	`54`
`60`	`55`	`public function GetInfo( )`