Skip to content
This repository was archived by the owner on May 1, 2024. It is now read-only.

Commit aba6205

Browse files
jfversluisJoacimWalljoacim wallAndreiMisiukevichpictos
authored
Develop to Main for 1.1 (#1108)
* Added new TextCaseType to TextCaseConverter (#763) * Added new TextCaseType to TextCaseConverter Added support for first char to upper rest to lower case. * Update src/CommunityToolkit/Xamarin.CommunityToolkit/Converters/TextCaseConverter.shared.cs * Added unit tests and fix bug for empty string * Update src/CommunityToolkit/Xamarin.CommunityToolkit/Converters/TextCaseConverter.shared.cs * Update src/CommunityToolkit/Xamarin.CommunityToolkit/Converters/TextCaseConverter.shared.cs * Update src/CommunityToolkit/Xamarin.CommunityToolkit/Converters/TextCaseConverter.shared.cs Co-authored-by: Pedro Jesus <[email protected]> Co-authored-by: joacim wall <[email protected]> Co-authored-by: Andrei <[email protected]> Co-authored-by: Pedro Jesus <[email protected]> * Add LocalizedString class for automatic ViewModel string updates (#750) * Add LocalizedString * Update test name * Remove from NETSTANDARD1_0 * LangVersion latest * Revert "LangVersion latest" This reverts commit e22a4c1. * Not using linq discard * Fix test * Fix test. Add constructor with localizationManager * Add new feature to sample app * Add Dispose() to unsubscribe from localizationManager.PropertyChanged * Fix Sample localization resources generation * Update sample app to change AppResources.Culture * Update LocalizedString to use ObservableObject * Return unsubscribing from localizationManager.PropertyChanged * Add WeakSubscribe * Refactor LocalizedString to use WeakSubscribe * Add test to ensure instance of LocalizedString is disposed * Dont create instance of LocalizationResourceManager * Add null checks to WeakSubscribe * Invoke action with less code null check has already been done * Replace spaces with tabs * Revert "Use Single for getting culture" * added one more unit test Co-authored-by: Pedro Jesus <[email protected]> * Add CommandFactory class (#797) * Create CommandHelper.shared.cs * Use CommandHelper in Sample app * Rename to CommandFactory * Replace "is null" with "== null" * Update GravatarImageViewModel.cs * Update SearchViewModel.cs * Move CommandFactory to ObjectModel * Update ConvertExecute and ConvertCanExecute to throw InvalidCommandParameterException * Add tests * Skip test in question * Revert Xamarin.CommunityToolkit.csproj changes * Fix tests * Add tests for AsyncValueCommand * Revert AsyncValueCommandSupport * Revert "Revert AsyncValueCommandSupport" This reverts commit 07a178c. * Creating AsyncValueCommand using CreateValue * Revert "Creating AsyncValueCommand using CreateValue" This reverts commit 7b32561. * Add Create overloads without optional parameters for Task to act as tiebreakers * Add different names to "execute" parameters to provide another way to resolve ambiguity * Updated CommandFactory - Add XML Documentation - Separated Command.Factory.Command.shared.cs, Command.Factory.IAsyncCommand.shared.cs and Command.Factory.IAsyncValueCommand.shared.cs - Removed unnecessary CommandFactory.Create methods - Added missing CommandFactory.Create methods - Updated Unit Tests * Updated XML Documentation Co-authored-by: Brandon Minnick <[email protected]> * Deprecate LocalizationResourceManager.SetCulture (#766) * Deprecate SetCulture * Add EditorBrowsableState.Never * Update src/CommunityToolkit/Xamarin.CommunityToolkit/Helpers/LocalizationResourceManager.shared.cs * Fix obsolete warning in tests * Remove unneeded line * Use new LocalizationResourceManager for tests Tests were failing from time to time because the same instance of LRM was used for all of them. And since tests are executed in parallel, this caused some issues * Siplify impicit conversion test to test only conversion itself * Return Invalidate mathod Co-authored-by: Pedro Jesus <[email protected]> * ShadowEffect (#725) * #461 * Added mac support * Added sample * Updated shadows * Fixed iOS crash * removed pragma * Remove effect when color if default * cleaned code * Implemented LazyView (#796) * Created LazyView and implemented it on TabView * Added Preserve attribute * Update LazyTestView.xaml * Adds Popup Control (#653) * Ported Popup Control from xamarin/Xamarin.Forms#9616 to Xamarin Community Toolkit * Added missing async/await api * Added popup result sample and fixed uwp/android implementations * Renamed View->Content * Updated styles of sample popups * Updated BorderColor to be a platform specific property for UWP * Moved Android/iOS/UWP renderers to platform specific folders * Changed PopupDismissedEventArgs so it is immutable * Removed visual studio edits to sample android project * Removed = false for isDisposed as it is default * Normalized accessor properties for ios and uwp * Removed performance apis since they are used internally at Xamarin.Forms * Simplified OnElementChanged to use shared method ConfigureControl * Removed iOS 9 code * Updated NavigationExtensions to follow Xamarin Essentials style by adding netstandard impl that throws exception * Added Control.Cleanup invocation to dispose method * [iOS] Removed async/await from OnDismissed since it is an event the invocation doesn't need to know when it is complete * Fixed comment * Updated iOS to use WeakEventManager * changed instantiation to use default(SizeRequest) * ios - Changed WeakEventManager so it is a protected static object on the popup renderer. This will help create a weak reference to the popup delegate for the GC * Moved sample popup code to new location * Added WeakEventManager for BasePopup events (Opened, Dismissed) * ios - changed popover delegate to use action * Added PopOverDelegate.PopoverDismissed * Updated accessor for LightDismiss to protected internal * Updated comment in LightDismiss * Removed stale iOS code * Updated xml comments * Removed obj dir from compilation in 'netstandard' projects and fixed debugger issues * removed Init method and added code to get the Context * changed accessor of ToolkitPlatform to internal * Added new UI popup tests for Xaml binding vs C# binding * Updated XCT xmlns to use uri instead of fully qualified namespace * Added shared popup size across samples * Fixed popup BindingContext not working when set in XAML * Update Samples - Capitalize x:Name variables - Replace expression-bodied properties with read-only properties where applicable * Add PopupDismissedEventArgs<T> * Add Default Values for Color and Size * Remove Unncessary `base` Keyword, per styling guide * Optimize originX + originX, Add missing `await` * Update PopupAnchorViewModel.cs * Fix orignY Copy/paste error * Update PopupRenderer.ios.cs * Update NavigationExtensions.netstandard.macos.tvos.watchos.tizen.wpf.gtk.cs * Added NavigableElementExtension - This allows rendering popup from ContentPage and other children of NavigableElement Co-authored-by: Brandon Minnick <[email protected]> Co-authored-by: Pedro Jesus <[email protected]> * Update BaseGalleryViewModel.cs * Merging is hard * Fix Anchor Popup Sample NRE (#834) * Changed LoadView to be Async (#828) * Changed LoadView to ValueTask LoadViewAsync and added summaries * Update src/CommunityToolkit/Xamarin.CommunityToolkit/Views/LazyView/LazyView.shared.cs * Popup out of the screen horizontally in Android sample (#839) * Fix popup out of horizontal bounds #653 (comment) * Device Size dependent * Essentials namespace * revert * [Android] Converting dimensions to pixels in popup renderer (#856) * [Android] Converting dimensions to pixels in popup renderer * Add fixed and relative to screen sizes instead of platform specific sizes. * Update ButtonPopup size. * Update CsharpBindingPopup size. * Update MultipleButtonPopup size. * Update NoLightDismissPopup size. * Update OpenedEventSimplePopup size. * Update ReturnResultPopup size. * Update SimplePopup size. * Update ToggleSizePopup size. * Update TransparentPopup size. * Update XamlBindingPopup size. * #704 [Bug] No padding around text in a Toast or Snackbar (#714) * Make ShieldView more customizable (#874) * Add SubjectBackgroundColor, SubjectTextColor/reorganization. * Update sample. * Obsolete message * Correct typo in comment Co-authored-by: Gerald Versluis <[email protected]> * Drop UpdateTextColor() Co-authored-by: Gerald Versluis <[email protected]> * fixed csproj to produce sourcelink (#893) * [iOS] Remove popup arrow if anchor isn't set (#854) * Remove popup arrow if anchor isn't set * Create PopoverArrowDirection.cs * Create Popup.shared.cs * Add arrow direction platform specific. * Add arrow direction platform specific sample. * Rename PopoverArrowDirection.cs to PopoverArrowDirection.shared.cs * Change ArrowDirection to up * Remove switch PopoverArrowDirection.None since default is already zero. * Use div 2 instead of multiply by 0.5 for consistency. Co-authored-by: Sebastian Klatte <[email protected]> * ProgressBar Attached Property to enable progress animation (#352) * ProgressBar Attached Property to enable progress animation * Fixes remarks on PR * Fix remarks PR * Changes need for new gallery viewmodel * Correct version from before rebase * Update AttachedPropertiesGalleryViewModel.cs * Update ProgressBarAttachedProperties.shared.cs * Update ProgressBarAttachedProperties.shared.cs * Change Attached property to behavior * Update samples/XCT.Sample/Xamarin.CommunityToolkit.Sample.csproj Co-authored-by: Andrei <[email protected]> * Update src/CommunityToolkit/Xamarin.CommunityToolkit/Behaviors/ProgressBarAnimationBehavior.cs Co-authored-by: Andrei <[email protected]> * Update src/CommunityToolkit/Xamarin.CommunityToolkit/Xamarin.CommunityToolkit.csproj Co-authored-by: Andrei <[email protected]> * Update src/CommunityToolkit/Xamarin.CommunityToolkit/Behaviors/ProgressBarAnimationBehavior.cs Co-authored-by: Cfun <[email protected]> * Update src/CommunityToolkit/Xamarin.CommunityToolkit/AttachedProperties/ProgressBarAttachedProperties.shared.cs Co-authored-by: Cfun <[email protected]> * Remove old attached property and rename new behavior Co-authored-by: Gerald Versluis <[email protected]> Co-authored-by: Andrei <[email protected]> Co-authored-by: Cfun <[email protected]> * Merge main into dev (#913) * [Android] Fix Long Press blocks CollectionView selection (#764) * #760 * Moved helper methods to VisualElementExtensions * Update src/CommunityToolkit/Xamarin.CommunityToolkit/Extensions/VisualElementExtension.shared.cs * Update src/CommunityToolkit/Xamarin.CommunityToolkit/Extensions/VisualElementExtension.shared.cs Co-authored-by: Javier Suárez <[email protected]> Co-authored-by: Gerald Versluis <[email protected]> * [Android] Fix SideMenuView + Slider issue (#824) * [Android] Allow using slider inside SideMenu with disabled gestures #810 * Refactored gesture default threshold #810 * Cleaned code. Added linker safety code * Fixed build Co-authored-by: Javier Suárez <[email protected]> * Automated dotnet-format update (#837) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Remove `Device` dependency from command implementation (#825) (#830) * Remove `Device` dependency from command implementation (#804) * Move Xamarin.CommunityToolkit.ObjectModel.Internals classes to `Internals` folder * Add Platform-Specific MainThread Implementations, Update Unit Tests to Acommidate Context Switching * Update BaseCommand.uwp.cs * Add BaseCommand.wpf.cs * Finish BaseCommand.gtk.cs * Update BaseCommand.shared.cs Co-authored-by: Eugen Richter <[email protected]> Co-authored-by: Brandon Minnick <[email protected]> * Automated dotnet-format update (#865) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Fixes #859 (#864) Co-authored-by: Gerald Versluis <[email protected]> * ValidationBehavior: Added IsNotValid property (#836) * Added IsNotValid property to validators * small fix * Updated sample * #822 (#877) * Fixes AvatarView - Valid source images dont load for the first time they are created (#849) * #805 * Update src/CommunityToolkit/Xamarin.CommunityToolkit/Views/AvatarView/AvatarView.shared.cs Co-authored-by: Gerald Versluis <[email protected]> * Fixed image loading * Fixed null ref * Fixes crashes Co-authored-by: Gerald Versluis <[email protected]> Co-authored-by: Javier Suárez <[email protected]> Co-authored-by: Pedro Jesus <[email protected]> * Added inline docs (#882) * Update ViewsGalleryViewModel.cs (#888) removed duplicated text "used to" * Document all behaviors and associated (#895) * Housekeeping remove XamlCompilation from code-behind. (#897) * Changed TabView SelectedIndex property to use TwoWay binding mode (#903) * Add inline Docs/Comments to Converters (#907) * Update azure-pipelines.yml Co-authored-by: Andrei <[email protected]> Co-authored-by: Javier Suárez <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Eugen Richter <[email protected]> Co-authored-by: Eugen Richter <[email protected]> Co-authored-by: Brandon Minnick <[email protected]> Co-authored-by: Pedro Jesus <[email protected]> Co-authored-by: WillAutioItrax <[email protected]> Co-authored-by: Cfun <[email protected]> * Add "Add(IEnumerable<T> collection)" to ObservableRangeCollection<T> (#891) * Create ObservableRangeCollectionEx.shared.cs * Add test * Update src/CommunityToolkit/Xamarin.CommunityToolkit/ObjectModel/Extensions/ObservableRangeCollectionEx.shared.cs * Resolve comments * Add AddToNullCollection test * Fix WeakSubscribe parameter type * Revert "Fix WeakSubscribe parameter type" This reverts commit 221ee0f. Co-authored-by: Andrei <[email protected]> * Update INotifyPropertyChangedEx.shared.cs (#918) * [Breaking Changes] ValidationBehavior Async checks support (#912) * Refactored validation behavior * Refactored to ValueTask * added configure await false * Fixed isRunning * LifeCycleEvents (#674) * Created LifeCycleEffect and platform implementations * Added sample to LifeCycle effect * refactor UnLoaded logic * clean up csproj * Fixed NRE for shell * Code Review fixes * code style * improved the sample * fixed tizen path * Fixed iOS support * Implemented WeakEventManager * Added inline docs/comments * changed to nameof * Msbuild hotfix (#946) * fixed msbuild instructions * revert android sample csproj * Add `Grouping` class from Refractored.MvvmHelpers (#957) * Fix LocalizedString gets unsubscribed while still in use (#987) * Fixed all the things * Make PersistentObservableObject abstract * Reverse the inheritance * Commit to rerun tests * Remove PersistentObservableObject * Grammar * Feature/371 enum boolean converter (#925) * Implement EnumToBoolConverter (#371) * Add example for EnumToBoolConverter * Make it work with flagged enums (#371) * Simplify code (#371) * Make the method an local static method (#371) * Cache enum type info (#371) Co-authored-by: Eugen Richter <[email protected]> * Add VSM to ValidationBehavior (#955) * Add VSM to ValidationBehavior * dumb commit: Re trigger CI * Fix typo * Fix typo Co-authored-by: Andrei <[email protected]> * Change string properties to public * Apply Pascal Case Naming * Update src/CommunityToolkit/Xamarin.CommunityToolkit/Behaviors/Validators/ValidationBehavior.shared.cs * Update src/CommunityToolkit/Xamarin.CommunityToolkit/Behaviors/Validators/ValidationBehavior.shared.cs * Update src/CommunityToolkit/Xamarin.CommunityToolkit/Behaviors/Validators/ValidationBehavior.shared.cs * Update src/CommunityToolkit/Xamarin.CommunityToolkit/Behaviors/Validators/ValidationBehavior.shared.cs * Update src/CommunityToolkit/Xamarin.CommunityToolkit/Behaviors/Validators/ValidationBehavior.shared.cs Co-authored-by: Andrei <[email protected]> * Fix Singleton Pattern for LocalizationResourceManager (#919) * Update LocalizationResourceManager.shared.cs * Implement Lazy Loading for Thread Safety * Fix Namespace * Removed changes from main branch * Revert Commit * Update LocalizationResourceManager.shared.cs * Fix Unit Tests * Add Collection to LocalizationResourceManagerTests The `Collection` attribute prevents these tests from running in parallel https://xunit.net/docs/running-tests-in-parallel.html * [Enhancement] Add Scale support for SideMenuView (#1011) * SideMenu scaling #1007 * Added easing * Update azure-pipelines.yml * [iOS] Fix missing binding context for popup view (#1003) * [iOS] Fix missing binding context for popup view * Fix handle binding context changes. * Enable Nullable (#1009) * Enable Nullable on Unit Tests (#1008) * Enable Nullability on Xamarin.CommunityToolkit.Markup (#1013) * Enable Nullable on Unit Tests * Enable Nullable on Xamarin.CommunityToolkit.Markup * Enable Nullability on Xamarin.CommunityToolkit.Sample (#1014) * Enable Nullable on Unit Tests * Enable Nullable on Xamarin.CommunityToolkit.Markup * Enable Nullable on Xamarin.CommunityToolkit.Sample * Enable Nullability for Android, GTK, iOS, Tizen, UWP & WPF Sample Projects (#1015) * Enable Nullable on Unit Tests * Enable Nullable on Xamarin.CommunityToolkit.Markup * Enable Nullable on Xamarin.CommunityToolkit.Sample * Enable Nullable on Android, GTK, iOS and Tizen Samples * Enable Nullable for UWP & WPF Sample Projects * Enable Nullability on Xamarin.CommunityToolkit (#1016) * Enable Nullable on Unit Tests * Enable Nullable on Xamarin.CommunityToolkit.Markup * Enable Nullable on Xamarin.CommunityToolkit.Sample * Enable Nullable on Android, GTK, iOS and Tizen Samples * Enable Nullable for UWP & WPF Sample Projects * Add Nullability * Enable Nullable on XamarinCommunityToolkit (#1023) * Enable Nullable on Unit Tests * Enable Nullable on Xamarin.CommunityToolkit.Markup * Enable Nullable on Xamarin.CommunityToolkit.Sample * Enable Nullable on Android, GTK, iOS and Tizen Samples * Enable Nullable for UWP & WPF Sample Projects * Add Nullability * Resolve Possible Null References * Removed Possible Null References * Update AppResources.Designer.cs * Handle Nullability * Updated Nullabiltiy * Update Converters & Unit Tests * Resolve MediaSource Unit Tests * Fix Unit Tests (#1036) * Enable Nullable on Unit Tests * Enable Nullable on Xamarin.CommunityToolkit.Markup * Enable Nullable on Xamarin.CommunityToolkit.Sample * Enable Nullable on Android, GTK, iOS and Tizen Samples * Enable Nullable for UWP & WPF Sample Projects * Add Nullability * Resolve Possible Null References * Removed Possible Null References * Update AppResources.Designer.cs * Handle Nullability * Updated Nullabiltiy * Update Converters & Unit Tests * Resolve MediaSource Unit Tests * Fix VariableMultiValueConverter * Fixed ImpliedOrderGridBehavior * Update NumericValidationBehavior.shared.cs * Resolve Nullable in SideMenuView * Move <Nullable>enable</Nullable> to Directory.Build.props * Update Xamarin.CommunityToolkit.Sample.csproj * Revert Designer.cs * Update Xamarin.CommunityToolkit.Sample.csproj * Update ItemSelectedEventArgsConverter_Tests.cs * Update SearchViewModel.cs * Update ItemTappedEventArgsConverter_Tests.cs * Update Xamarin.CommunityToolkit.UnitTests.csproj * Add Nullability * Resolve Compiler Warnings * Ignore Closing square brackets should be spaced correctly With Nullable enabled, `byte[]?` is now valid, however SA1011 was still generating a warning * Update src/CommunityToolkit/Xamarin.CommunityToolkit/Behaviors/ImpliedOrderGridBehavior.shared.cs Co-authored-by: Pedro Jesus <[email protected]> * Update CameraFragment.android.cs * Update CameraFragment.android.cs * Update ImpliedOrderGridBehavior.shared.cs * Update MaskedBehavior.shared.cs * Update PopupRenderer.uwp.cs * Use .NET 5.0 * Update azure-pipelines.yml * Update azure-pipelines.yml * Update azure-pipelines.yml * Add UWP to Release Build * Update Nullability * Update Nullablity * Update TabView.shared.cs * Update Nullability * Revert "Update Nullability" This reverts commit e391b9c. * Resolved Nullable * Update azure-pipelines.yml * Revert UWP Build Properties * Update azure-pipelines.yml * Update azure-pipelines.yml * Revert "Update azure-pipelines.yml" This reverts commit 0842280. * Update azure-pipelines.yml * Revert "Revert UWP Build Properties" This reverts commit 77226bf. * Update azure-pipelines.yml * Update azure-pipelines.yml * Update azure-pipelines.yml * Update azure-pipelines.yml * Update azure-pipelines.yml * Update azure-pipelines.yml * Revert "Update azure-pipelines.yml" This reverts commit 4eb36f4. * Update azure-pipelines.yml * Revert "Update azure-pipelines.yml" This reverts commit e41a477. * Fix ValidationBehavior.ForceValidate and ValidationBehavior.DefaultForceValidateCommand * Update SelectAllTextEffect.ios.cs * Remove Nullabilty from LocalizedString.generator * Update MediaElementRenderer.ios.cs * Update PopupRenderer.uwp.cs * Update PopupRenderer.ios.cs * Update src/CommunityToolkit/Xamarin.CommunityToolkit/Views/Snackbar/Helpers/iOS/SnackbarViews/BaseSnackBarView.ios.cs Co-authored-by: Maksym Koshovyi <[email protected]> * Update TranslateExtension.shared.cs * Update src/CommunityToolkit/Xamarin.CommunityToolkit/Views/Snackbar/SnackBar.android.cs Co-authored-by: Maksym Koshovyi <[email protected]> * Update Logic * Fix Failing ICommand Tests * Update src/CommunityToolkit/Xamarin.CommunityToolkit/Views/Snackbar/SnackBar.tizen.cs Co-authored-by: Maksym Koshovyi <[email protected]> * Throw Faulted Task * Use Cast instead of Pattern Matching * Update RangeSlider.shared.cs * Fix missing semi-colons * Throw InvalidOperationException in LocalizationResourceManager * Make TranslateExtension.StringFormat nullable * Update UserStoppedTypingBehavior.shared.cs * Update SearchPage.logic.cs * Update TouchEffectCollectionViewPage.xaml.cs * Update AppResources.Designer.cs * Update AppResources.Designer.cs * Update EnumToBoolConverterViewModel.cs * Update EnumToBoolConverter_Tests.cs * Update IntToBoolConverter_Tests.cs * Update InvertedBoolConverter_Tests.cs * Update IsNotNullOrEmptyConverter_Tests.cs * Update MultiConverter_Tests.cs * Update NotEqualConverter_Tests.cs * Update TextCaseConverter_Tests.cs * Update MockPlatformServices.cs * Update MockPlatformServices.cs * Update Namespace_Tests.cs * Update ObservableRangeCollection_Tests.cs * Update ObservableRangeCollection_Tests.cs * Use `async Task` instead of `async void` * Update MultiValidationBehavior.shared.cs * Update EnumToBoolConverter.shared.cs * Update EnumToBoolConverter.shared.cs * Update src/CommunityToolkit/Xamarin.CommunityToolkit/Converters/NotEqualConverter.shared.cs Co-authored-by: Pedro Jesus <[email protected]> * Update src/CommunityToolkit/Xamarin.CommunityToolkit/Converters/StateToBooleanConverter.shared.cs Co-authored-by: Pedro Jesus <[email protected]> * Update src/CommunityToolkit/Xamarin.CommunityToolkit/Converters/TextCaseConverter.shared.cs Co-authored-by: Pedro Jesus <[email protected]> * Update IconTintColorEffectRouter.android.cs * Update src/CommunityToolkit/Xamarin.CommunityToolkit/Effects/SelectAllText/SelectAllTextEffect.android.cs Co-authored-by: Pedro Jesus <[email protected]> * Update SelectAllTextEffect.android.cs * Update SelectAllTextEffect.ios.cs * Update PlatformTouchEffect.ios.cs * Update PlatformTouchEffect.uwp.cs * Update PlatformTouchEffect.uwp.cs * Update PlatformTouchEffect.macos.cs * Update PlatformTouchEffect.uwp.cs * Update PlatformTouchEffect.uwp.cs * Ensure nullable results from BindableProperties are still resolved * Update ImageResourceExtension.shared.cs * Update BaseCommand.android.cs * Use protected private constructor for BaseCommand * Update BadgeView.shared.cs * Update CameraFragment.android.cs * Fix Android Media Bugs * Update async/await * Update CameraView_Tests.cs * Update CameraView * Update UriTypeConverter.shared.cs * Update PopupRenderer.uwp.cs * Update PopoverArrowDirection.shared.cs * Update PopoverArrowDirection.shared.cs * Update TabView.shared.cs * Improve AsyncCommand Tests * Ensure Context is non nullable * Remove Missing Translations * Fix async/await in TouchEffect.shared.cs * Make Easing Nullable * Update Samples * Fix Null Exception * Resolve NullReferenceExceptions * Make IBadgeAnimation Nullable * Add ShutterCommandValueCreator null check * Add Timeout to prevent race conditions from stalling tests * Unsubscribe Event Handlers for AsyncCommand Tests * Update azure-pipelines.yml * For WPF, Use Cross-Platform Implementation for `BaseCommand.IsMainThread` and `BaseCommand.BeginInvokeOnMainThread` (#965) * Add Non-WPF Support to .NET Core 3.1 * Update comments * Merge .NET Standard and WPF Functionality * Fix Null Reference * Update ICommand_AsyncValueCommand_Tests.cs * Add volatile keyword * Update AsyncValueCommand_Tests.cs * Remove Timeouts * Fix Event Unsubscription * Add .ConfigureAwait(false); * Run dotnet test serially * Use SemaphoreSlim to prevent Race Conditions Co-authored-by: Pedro Jesus <[email protected]> Co-authored-by: Maksym Koshovyi <[email protected]> * add SetFocusOnEntryCompleted (#841) (#911) * add SetFocusOnEntryCompleted (#841) * prevent SetFocusOnEntryCompleted memory leak (#841) also force exception if used on non-Entry * cleanup (reuse variable) (#841) * change to attached behavior SetFocusOnEntryCompletedBehavior * remove AttachedBehaviors sub-namespace * fix SetFocusOnEntryCompleted_Tests * simplify SetFocusOnEntryCompletedBehaviorPage * fixed code to be nullable safe * code style Co-authored-by: Pedro Jesus <[email protected]> * #1046 (#1052) * #1025 (#1042) * Merge fixing * Implement SafeFireAndForgetExtensions (#1054) * Implement Safe-Fire-And-Forget * Change `public` to `internal` * Update PlatformTouchEffect.android.cs * Regression #853 (#1063) * [iOS] Fix popup default color and dark mode (#1041) * [iOS] Fix popup default color and dark mode * [Android] Set correct background for default color * [Android] GetWindowColor() for popup background color * Update src/CommunityToolkit/Xamarin.CommunityToolkit/Views/Popup/Android/PopupRenderer.android.cs * Update src/CommunityToolkit/Xamarin.CommunityToolkit/Views/Popup/Android/PopupRenderer.android.cs * Update BasePopup.shared.cs * Update PopupRenderer.android.cs * Update PopupRenderer.android.cs * Update src/CommunityToolkit/Xamarin.CommunityToolkit/Views/Popup/BasePopup.shared.cs Co-authored-by: Andrei <[email protected]> Co-authored-by: Brandon Minnick <[email protected]> * Add remove border effect implementation for uwp (#1048) Co-authored-by: Alexander Witkowski <[email protected]> * Added long press event #851 (#1064) * Update LocalizedString.shared.cs (#1071) * Image resource converter (#1068) * Implement ImageResourceConverter * Add a sample for ImageResource extension * Fix nullable errors * Rename converter file to be compiled. * Better exception message Co-authored-by: Andrei <[email protected]> * Update samples/XCT.Sample/ViewModels/Converters/ImageResourceConverterViewModel.cs * Update src/CommunityToolkit/Xamarin.CommunityToolkit/Converters/ImageResourceConverter.shared.cs * Update samples/XCT.Sample/ViewModels/Converters/ImageResourceConverterViewModel.cs * Update samples/XCT.Sample/ViewModels/Converters/ImageResourceConverterViewModel.cs * Update samples/XCT.Sample/ViewModels/Converters/ImageResourceConverterViewModel.cs * Fix GalleryPage and VM * Update samples/XCT.Sample/ViewModels/Extensions/ExtensionsGalleryViewModel.cs Co-authored-by: Andrei <[email protected]> * Update samples/XCT.Sample/ViewModels/Extensions/ExtensionsGalleryViewModel.cs Co-authored-by: Andrei <[email protected]> * Replace Exception approach by extension used by XF (#1028) * Replace Exception approach by extension used by XF * Simplified syntax as requested * Add a missing namespace * Resolve `IAsyncCommand` / `IAsyncValueValueCommand` Unit Test Race Condition (#1076) * Add Unit Test Timeouts * Add macOS Unit Tests * Build 'samples/XCT.Sample.sln' on macOS * Restore Unit Test NuGet Packages * Fix YAML formatting * Add xunit.runner.console * Use latest stable version of Microsoft.NET.Test.Sdk * Fix Unit Tests on macos * Update azure-pipelines.yml * Update azure-pipelines.yml * Update azure-pipelines.yml * Add SemaphoreSlim * Add `dotnet restore` * Update azure-pipelines.yml * Update azure-pipelines.yml * Revert "Add SemaphoreSlim" This reverts commit 6875865. * Revert BaseCommand.semaphoreSlim * Update azure-pipelines.yml * Update azure-pipelines.yml * Update azure-pipelines.yml * Add ConfigureAwait(false) to ValueTaskDelay(int) * Change Platform from NetCore to macOS * Passthrough ValueTask * Update azure-pipelines.yml * Revert "Update azure-pipelines.yml" This reverts commit d7b2842. * Use ConfigureAwait(false) * Rename Task * Remove `static` * Remove `static` * Revert p:BuildInParallel=false * Update azure-pipelines.yml * Revert "Update azure-pipelines.yml" This reverts commit bf93f0c. * Revert "Revert "Update azure-pipelines.yml"" This reverts commit 031121a. * Revert "Revert "Revert "Update azure-pipelines.yml""" This reverts commit 458feb2. * #1066 (#1078) Co-authored-by: Brandon Minnick <[email protected]> * fix badge background color (#1080) (#1081) Co-authored-by: Matthew S <[email protected]> Co-authored-by: Brandon Minnick <[email protected]> Co-authored-by: Pedro Jesus <[email protected]> * allow TextCaseConverter to handle any value type (#1053) * allow TextCaseConverter to handle any value type * remove duplicate Convert method * fix nullability * update TextCaseConverter tests * Update src/CommunityToolkit/Xamarin.CommunityToolkit/Converters/TextCaseConverter.shared.cs Co-authored-by: Andrei <[email protected]> Co-authored-by: Brandon Minnick <[email protected]> Co-authored-by: Pedro Jesus <[email protected]> * #850 (#1056) Co-authored-by: Brandon Minnick <[email protected]> Co-authored-by: Pedro Jesus <[email protected]> * Platform specific API (#949) * added iOS platformSpecific * added UWP platform specific * Changed the sample * code clean up * added null check for Element Co-authored-by: Brandon Minnick <[email protected]> Co-authored-by: Gerald Versluis <[email protected]> * Add some null checks (#1033) Co-authored-by: Brandon Minnick <[email protected]> Co-authored-by: Javier Suárez <[email protected]> Co-authored-by: Gerald Versluis <[email protected]> * Migrate Unit Tests to NUnit (#1090) * Migrate to NUnit * Update Tests * Update Azure Pipelines * Update TextCaseConverter_Tests.cs * Update DateTimeOffsetConverter_Tests.cs * Increase Timeout * Increase Timeout * Add `const int defaultTimeoutThreshold` Co-authored-by: Gerald Versluis <[email protected]> * Enable Nullable for Xamarin.CommunityToolkit.Markup.UnitTests (#1086) * Add Markup Unit Tests * Add Nullable to Xamarin.CommunityToolkit.Markdown.UnitTests * Update BindingHelpers.cs * Fix Failing Unit Tests * Don't capture XUnit's Synchronization Context * Re-order Unit Tests * Revert "Don't capture XUnit's Synchronization Context" This reverts commit b8b3f16. Co-authored-by: Javier Suárez <[email protected]> * Implement a generic version of the EventToCommandBehavior (#1010) * created ECBGeneric * Added Generic implemention to the EventToCommandBehavior * make EventToCommandBehavior<TType> sealed * Fixed for value types * added nullable notations * update the comment * fixed unit test * Migrate Unit Tests to NUnit * Fixed unitTest * changed to use C#9 features * removed Convert method * Add Inheritance Test Co-authored-by: Gerald Versluis <[email protected]> Co-authored-by: Brandon Minnick <[email protected]> * [UWP] TouchEffect OnPointerReleased crash (#1088) * Fixed TouchEffect UWP crash * Touch Effect more nullRef fixes * fixed build * fix build Co-authored-by: Javier Suárez <[email protected]> Co-authored-by: Pedro Jesus <[email protected]> Co-authored-by: Brandon Minnick <[email protected]> Co-authored-by: Joacim Wall <[email protected]> Co-authored-by: joacim wall <[email protected]> Co-authored-by: Andrei <[email protected]> Co-authored-by: Pedro Jesus <[email protected]> Co-authored-by: Maksym Koshovyi <[email protected]> Co-authored-by: Brandon Minnick <[email protected]> Co-authored-by: Andrew Hoefling <[email protected]> Co-authored-by: Cfun <[email protected]> Co-authored-by: Sebastian Klatte <[email protected]> Co-authored-by: Vladislav Antonyuk <[email protected]> Co-authored-by: Sebastian Klatte <[email protected]> Co-authored-by: Glenn Versweyveld <[email protected]> Co-authored-by: Javier Suárez <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Eugen Richter <[email protected]> Co-authored-by: Eugen Richter <[email protected]> Co-authored-by: WillAutioItrax <[email protected]> Co-authored-by: tranb3r <[email protected]> Co-authored-by: Jacob Egner <[email protected]> Co-authored-by: Alexander Witkowski <[email protected]> Co-authored-by: Alexander Witkowski <[email protected]> Co-authored-by: Matthew S <[email protected]> Co-authored-by: Matthew S <[email protected]> Co-authored-by: Dan Siegel <[email protected]>
1 parent 1ae67e1 commit aba6205

File tree

454 files changed

+12145
-4647
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

454 files changed

+12145
-4647
lines changed

‎.editorconfig‎

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -107,3 +107,9 @@ csharp_new_line_before_catch = true
107107
csharp_new_line_before_finally = true
108108
csharp_new_line_before_members_in_object_initializers = true
109109
csharp_new_line_before_members_in_anonymous_types = true
110+
111+
# SA1011: Closing square brackets should be spaced correctly
112+
dotnet_diagnostic.SA1011.severity = none
113+
114+
# CS4014: Because this call is not awaited, execution of the current method continues before the call is completed
115+
dotnet_diagnostic.CS4014.severity = error

‎Directory.Build.props‎

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,12 @@
22
<Project xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
33

44
<PropertyGroup>
5-
<LangVersion>8.0</LangVersion>
5+
<LangVersion>9.0</LangVersion>
6+
<Nullable>enable</Nullable>
7+
<WarningsAsErrors>nullable</WarningsAsErrors>
68
</PropertyGroup>
79

10+
811
<PropertyGroup>
912
<CodeAnalysisRuleSet>$(MSBuildThisFileDirectory)Xamarin.CommunityToolkit.ruleset</CodeAnalysisRuleSet>
1013
<TreatWarningsAsErrors>false</TreatWarningsAsErrors>

‎Xamarin.CommunityToolkit.ruleset‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,6 @@
1515
<Rule Id="SA1008" Action="Warning" />
1616
<Rule Id="SA1009" Action="Warning" />
1717
<Rule Id="SA1010" Action="Warning" />
18-
<Rule Id="SA1011" Action="Warning" />
1918
<Rule Id="SA1012" Action="Warning" />
2019
<Rule Id="SA1013" Action="Warning" />
2120
<Rule Id="SA1014" Action="Warning" />

‎azure-pipelines.yml‎

Lines changed: 64 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -6,11 +6,16 @@ variables:
66
NugetPackageVersion: '$(CurrentSemanticVersion)'
77
#MONO_VERSION: 6_4_0
88
#XCODE_VERSION: 11.4
9-
NETCORE_VERSION: '3.1.x'
10-
NETCORE_TEST_VERSION: '3.1.x'
9+
NETCORE_VERSION: '5.0.x'
10+
NETCORE_TEST_VERSION_3_1: '3.1.x'
11+
NETCORE_TEST_VERSION_2_1: '2.1.x'
1112
RunPoliCheck: 'false'
12-
PathToCsproj: 'src/CommunityToolkit/Xamarin.CommunityToolkit/Xamarin.CommunityToolkit.csproj'
1313
PathToMarkupCsproj: 'src/Markup/Xamarin.CommunityToolkit.Markup/Xamarin.CommunityToolkit.Markup.csproj'
14+
PathToCommunityToolkitCsproj: 'src/CommunityToolkit/Xamarin.CommunityToolkit/Xamarin.CommunityToolkit.csproj'
15+
PathToSamplesSln: 'samples/XCT.Sample.sln'
16+
PathToCommunityToolkitUnitTestCsproj: 'src/CommunityToolkit/Xamarin.CommunityToolkit.UnitTests/Xamarin.CommunityToolkit.UnitTests.csproj'
17+
PathToMarkupUnitTestCsproj: 'src/Markup/Xamarin.CommunityToolkit.Markup.UnitTests/Xamarin.CommunityToolkit.Markup.UnitTests.csproj'
18+
PathToMsBuildOnMacOS: 'mono /Applications/Visual\ studio.app/Contents/Resources/lib/monodevelop/bin/MSBuild/Current/bin/MSBuild.dll'
1419
PathToSln: 'samples/XCT.Sample.sln'
1520

1621
resources:
@@ -68,6 +73,21 @@ jobs:
6873
pool:
6974
vmImage: windows-2019
7075
steps:
76+
- task: UseDotNet@2
77+
displayName: 'Install .NET SDK'
78+
inputs:
79+
version: $(NETCORE_VERSION)
80+
includePreviewVersions: false
81+
- task: UseDotNet@2
82+
displayName: 'Install .NET 3.1 Test SDK'
83+
inputs:
84+
version: $(NETCORE_TEST_VERSION_3_1)
85+
includePreviewVersions: false
86+
- task: UseDotNet@2
87+
displayName: 'Install .NET 2.1 Test SDK'
88+
inputs:
89+
version: $(NETCORE_TEST_VERSION_2_1)
90+
includePreviewVersions: false
7191
# if this is a tagged build, then update the version number
7292
- powershell: |
7393
$buildSourceBranch = "$(Build.SourceBranch)"
@@ -78,19 +98,19 @@ jobs:
7898
condition: startsWith(variables['Build.SourceBranch'], 'refs/tags/')
7999
# restore, build and pack the packages
80100
- task: MSBuild@1
81-
displayName: Build Solution
101+
displayName: Build Xamarin.CommunityToolkit.csproj
82102
inputs:
83-
solution: $(PathToCsproj)
103+
solution: $(PathToCommunityToolkitCsproj)
84104
configuration: Release
85105
msbuildArguments: '/restore /t:Build /p:ContinuousIntegrationBuild=true /p:Deterministic=false'
86106
- task: CopyFiles@2
87107
inputs:
88108
Contents: 'SignList.xml'
89109
TargetFolder: '$(Build.ArtifactStagingDirectory)/nuget'
90110
- task: MSBuild@1
91-
displayName: Pack NuGets
111+
displayName: Pack Community Toolkit NuGets
92112
inputs:
93-
solution: $(PathToCsproj)
113+
solution: $(PathToCommunityToolkitCsproj)
94114
configuration: Release
95115
msbuildArguments: '/t:Pack /p:PackageVersion=$(NugetPackageVersion) /p:PackageOutputPath="$(Build.ArtifactStagingDirectory)/nuget"'
96116
- task: MSBuild@1
@@ -112,12 +132,14 @@ jobs:
112132
# command: 'custom'
113133
# custom: 'nuget'
114134
# arguments: 'push --source https://nuget.pkg.github.com/xamarin/index.json --api-key $(GitHub.NuGet.Token) "$(Build.ArtifactStagingDirectory)\nuget\*.nupkg"'
115-
- task: DotNetCoreCLI@2
116-
displayName: Run Tests
135+
- task: CmdLine@2
136+
displayName: 'Run Markup Unit Tests'
137+
inputs:
138+
script: dotnet test $(PathToMarkupUnitTestCsproj) -c Release --collect "Code coverage" -p:BuildInParallel=false
139+
- task: CmdLine@2
140+
displayName: 'Run Community Toolkit Unit Tests'
117141
inputs:
118-
command: test
119-
projects: '**/*.UnitTests.csproj'
120-
arguments: '--configuration Release --collect "Code coverage"'
142+
script: dotnet test $(PathToCommunityToolkitUnitTestCsproj) -c Release --collect "Code coverage" -p:BuildInParallel=false
121143
# publish the packages
122144
- task: PublishBuildArtifacts@1
123145
displayName: 'Publish Unsigned NuGets'
@@ -161,27 +183,44 @@ jobs:
161183
# displayName: Switch to the latest Xcode
162184
# restore, build and pack the packages
163185
- task: UseDotNet@2
164-
displayName: 'Use .Net Core sdk'
186+
displayName: 'Install .NET SDK'
165187
inputs:
166188
version: $(NETCORE_VERSION)
167189
includePreviewVersions: false
168190
- task: UseDotNet@2
169-
displayName: 'Use .Net Core sdk'
191+
displayName: 'Install .NET 3.1 Test SDK'
170192
inputs:
171-
version: $(NETCORE_TEST_VERSION)
193+
version: $(NETCORE_TEST_VERSION_3_1)
172194
includePreviewVersions: false
173-
- task: MSBuild@1
174-
displayName: Build Solution
195+
- task: UseDotNet@2
196+
displayName: 'Install .NET 2.1 Test SDK'
175197
inputs:
176-
solution: $(PathToCsproj)
177-
configuration: Release
178-
msbuildArguments: '/restore /t:Build /p:ContinuousIntegrationBuild=true /p:Deterministic=false'
179-
- task: MSBuild@1
180-
displayName: Pack NuGets
198+
version: $(NETCORE_TEST_VERSION_2_1)
199+
includePreviewVersions: false
200+
- task: CmdLine@2
201+
displayName: 'Build Markup'
181202
inputs:
182-
solution: $(PathToCsproj)
183-
configuration: Release
184-
msbuildArguments: '/t:Pack /p:PackageVersion=$(NugetPackageVersion) /p:PackageOutputPath="$(Build.ArtifactStagingDirectory)/nuget"'
203+
script: '$(PathToMsBuildOnMacOS) $(PathToMarkupCsproj) /p:Configuration=Release /restore /t:Build /p:ContinuousIntegrationBuild=true /p:Deterministic=false'
204+
- task: CmdLine@2
205+
displayName: 'Build Community Toolkit'
206+
inputs:
207+
script: '$(PathToMsBuildOnMacOS) $(PathToCommunityToolkitCsproj) /p:Configuration=Release /restore /t:Build /p:ContinuousIntegrationBuild=true /p:Deterministic=false'
208+
- task: CmdLine@2
209+
displayName: 'Run Markup Unit Tests'
210+
inputs:
211+
script: 'dotnet test $(PathToMarkupUnitTestCsproj) /p:Configuration=Release -p:BuildInParallel=false'
212+
- task: CmdLine@2
213+
displayName: 'Run Community Toolkit Unit Tests'
214+
inputs:
215+
script: 'dotnet test $(PathToCommunityToolkitUnitTestCsproj) /p:Configuration=Release -p:BuildInParallel=false'
216+
- task: CmdLine@2
217+
displayName: 'Pack Markup NuGets'
218+
inputs:
219+
script: '$(PathToMsBuildOnMacOS) $(PathToMarkupUnitTestCsproj) /p:Configuration=Release /t:Pack /p:PackageVersion=$(NugetPackageVersion) /p:PackageOutputPath="$(Build.ArtifactStagingDirectory)/nuget"'
220+
- task: CmdLine@2
221+
displayName: 'Pack CommunityToolkit NuGets'
222+
inputs:
223+
script: '$(PathToMsBuildOnMacOS) $(PathToCommunityToolkitCsproj) /p:Configuration=Release /t:Pack /p:PackageVersion=$(NugetPackageVersion) /p:PackageOutputPath="$(Build.ArtifactStagingDirectory)/nuget"'
185224

186225
- ${{ if eq(variables['System.TeamProject'], 'devdiv') }}:
187226
- template: sign-artifacts/jobs/v2.yml@internal-templates

‎samples/XCT.Sample.Android/MainActivity.cs‎

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@
22
using Android.Content.PM;
33
using Android.OS;
44
using Android.Runtime;
5-
using Xamarin.Essentials;
65

76
namespace Xamarin.CommunityToolkit.Sample.Droid
87
{
@@ -17,14 +16,14 @@ protected override void OnCreate(Bundle savedInstanceState)
1716
base.OnCreate(savedInstanceState);
1817

1918
global::Xamarin.Forms.Forms.SetFlags("CollectionView_Experimental");
20-
Platform.Init(this, savedInstanceState);
19+
Essentials.Platform.Init(this, savedInstanceState);
2120
global::Xamarin.Forms.Forms.Init(this, savedInstanceState);
2221
LoadApplication(new App());
2322
}
2423

2524
public override void OnRequestPermissionsResult(int requestCode, string[] permissions, [GeneratedEnum] Permission[] grantResults)
2625
{
27-
Platform.OnRequestPermissionsResult(requestCode, permissions, grantResults);
26+
Essentials.Platform.OnRequestPermissionsResult(requestCode, permissions, grantResults);
2827

2928
base.OnRequestPermissionsResult(requestCode, permissions, grantResults);
3029
}

‎samples/XCT.Sample.Android/SplashActivity.cs‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ namespace Xamarin.CommunityToolkit.Sample.Droid
99
[Activity(Label = "XamarinCommunityToolkitSample", Icon = "@mipmap/icon", Theme = "@style/SplashTheme", MainLauncher = true, ConfigurationChanges = ConfigChanges.ScreenSize | ConfigChanges.Orientation)]
1010
public class SplashActivity : AppCompatActivity
1111
{
12-
protected override void OnCreate(Bundle savedInstanceState)
12+
protected override void OnCreate(Bundle? savedInstanceState)
1313
{
1414
base.OnCreate(savedInstanceState);
1515
var intent = new Intent(this, typeof(MainActivity));

‎samples/XCT.Sample.Android/Xamarin.CommunityToolkit.Sample.Android.csproj‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@
2525
</PropertyGroup>
2626
<PropertyGroup Condition=" '$(Configuration)|$(Platform)' == 'Debug|AnyCPU' ">
2727
<DebugSymbols>true</DebugSymbols>
28-
<DebugType>portable</DebugType>
28+
<DebugType>full</DebugType>
2929
<Optimize>false</Optimize>
3030
<OutputPath>bin\Debug</OutputPath>
3131
<DefineConstants>DEBUG;</DefineConstants>

‎samples/XCT.Sample.UWP/App.xaml.cs‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -85,7 +85,7 @@ protected override void OnLaunched(LaunchActivatedEventArgs e)
8585
/// </summary>
8686
/// <param name="sender">The Frame which failed navigation</param>
8787
/// <param name="e">Details about the navigation failure</param>
88-
void OnNavigationFailed(object sender, NavigationFailedEventArgs e)
88+
void OnNavigationFailed(object? sender, NavigationFailedEventArgs e)
8989
{
9090
throw new Exception("Failed to load Page " + e.SourcePageType.FullName);
9191
}
@@ -97,7 +97,7 @@ void OnNavigationFailed(object sender, NavigationFailedEventArgs e)
9797
/// </summary>
9898
/// <param name="sender">The source of the suspend request.</param>
9999
/// <param name="e">Details about the suspend request.</param>
100-
void OnSuspending(object sender, SuspendingEventArgs e)
100+
void OnSuspending(object? sender, SuspendingEventArgs e)
101101
{
102102
var deferral = e.SuspendingOperation.GetDeferral();
103103

‎samples/XCT.Sample.iOS/Renderers/NoLineNavigationRenderer.cs‎

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,8 +25,11 @@ public override void ViewWillAppear(bool animated)
2525
// Newest iOS version fix - trycatch isn't optimal
2626
try
2727
{
28-
NavigationBar.ScrollEdgeAppearance.ShadowImage = new UIKit.UIImage();
29-
NavigationBar.ScrollEdgeAppearance.ShadowColor = null;
28+
if (NavigationBar.ScrollEdgeAppearance != null)
29+
{
30+
NavigationBar.ScrollEdgeAppearance.ShadowImage = new UIKit.UIImage();
31+
NavigationBar.ScrollEdgeAppearance.ShadowColor = null;
32+
}
3033
}
3134
catch (Exception)
3235
{

‎samples/XCT.Sample.sln‎

Lines changed: 33 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -18,9 +18,9 @@ Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "Xamarin.CommunityToolkit.Sa
1818
EndProject
1919
Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "Solution Items", "Solution Items", "{F695F5E8-420F-475F-A4CF-F5BB3FA6E818}"
2020
ProjectSection(SolutionItems) = preProject
21-
.editorconfig = .editorconfig
22-
Directory.Build.props = Directory.Build.props
23-
Xamarin.CommunityToolkit.ruleset = Xamarin.CommunityToolkit.ruleset
21+
..\.editorconfig = ..\.editorconfig
22+
..\Directory.Build.props = ..\Directory.Build.props
23+
..\Xamarin.CommunityToolkit.ruleset = ..\Xamarin.CommunityToolkit.ruleset
2424
EndProjectSection
2525
EndProject
2626
Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "Xamarin.CommunityToolkit.Sample.WPF", "XCT.Sample.WPF\Xamarin.CommunityToolkit.Sample.WPF.csproj", "{C4D6CD2D-8DF4-4D46-936C-1AB31C87B5EA}"
@@ -31,6 +31,8 @@ Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "Xamarin.CommunityToolkit.Sa
3131
EndProject
3232
Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "Xamarin.CommunityToolkit.Markup", "..\src\Markup\Xamarin.CommunityToolkit.Markup\Xamarin.CommunityToolkit.Markup.csproj", "{A5AAB927-15D7-498C-8295-4209F21836CE}"
3333
EndProject
34+
Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "Xamarin.CommunityToolkit.Markup.UnitTests", "..\src\Markup\Xamarin.CommunityToolkit.Markup.UnitTests\Xamarin.CommunityToolkit.Markup.UnitTests.csproj", "{AAE423C4-E9B4-434E-885C-2164C12BF79C}"
35+
EndProject
3436
Global
3537
GlobalSection(SolutionConfigurationPlatforms) = preSolution
3638
Debug|Any CPU = Debug|Any CPU
@@ -62,6 +64,7 @@ Global
6264
{8B80BFA6-7B19-4DE7-BD97-7D84194AD0C2}.Debug|x86.Build.0 = Debug|Any CPU
6365
{8B80BFA6-7B19-4DE7-BD97-7D84194AD0C2}.Release|Any CPU.ActiveCfg = Release|Any CPU
6466
{8B80BFA6-7B19-4DE7-BD97-7D84194AD0C2}.Release|Any CPU.Build.0 = Release|Any CPU
67+
{8B80BFA6-7B19-4DE7-BD97-7D84194AD0C2}.Release|Any CPU.Deploy.0 = Release|Any CPU
6568
{8B80BFA6-7B19-4DE7-BD97-7D84194AD0C2}.Release|ARM.ActiveCfg = Release|Any CPU
6669
{8B80BFA6-7B19-4DE7-BD97-7D84194AD0C2}.Release|ARM.Build.0 = Release|Any CPU
6770
{8B80BFA6-7B19-4DE7-BD97-7D84194AD0C2}.Release|iPhone.ActiveCfg = Release|Any CPU
@@ -191,6 +194,8 @@ Global
191194
{91C748B4-E9ED-4543-880A-26747B03DE3A}.Debug|x86.Build.0 = Debug|x86
192195
{91C748B4-E9ED-4543-880A-26747B03DE3A}.Debug|x86.Deploy.0 = Debug|x86
193196
{91C748B4-E9ED-4543-880A-26747B03DE3A}.Release|Any CPU.ActiveCfg = Release|x86
197+
{91C748B4-E9ED-4543-880A-26747B03DE3A}.Release|Any CPU.Build.0 = Release|x86
198+
{91C748B4-E9ED-4543-880A-26747B03DE3A}.Release|Any CPU.Deploy.0 = Release|x86
194199
{91C748B4-E9ED-4543-880A-26747B03DE3A}.Release|ARM.ActiveCfg = Release|ARM
195200
{91C748B4-E9ED-4543-880A-26747B03DE3A}.Release|ARM.Build.0 = Release|ARM
196201
{91C748B4-E9ED-4543-880A-26747B03DE3A}.Release|ARM.Deploy.0 = Release|ARM
@@ -298,12 +303,37 @@ Global
298303
{A5AAB927-15D7-498C-8295-4209F21836CE}.Release|x64.Build.0 = Release|Any CPU
299304
{A5AAB927-15D7-498C-8295-4209F21836CE}.Release|x86.ActiveCfg = Release|Any CPU
300305
{A5AAB927-15D7-498C-8295-4209F21836CE}.Release|x86.Build.0 = Release|Any CPU
306+
{AAE423C4-E9B4-434E-885C-2164C12BF79C}.Debug|Any CPU.ActiveCfg = Debug|Any CPU
307+
{AAE423C4-E9B4-434E-885C-2164C12BF79C}.Debug|Any CPU.Build.0 = Debug|Any CPU
308+
{AAE423C4-E9B4-434E-885C-2164C12BF79C}.Debug|ARM.ActiveCfg = Debug|Any CPU
309+
{AAE423C4-E9B4-434E-885C-2164C12BF79C}.Debug|ARM.Build.0 = Debug|Any CPU
310+
{AAE423C4-E9B4-434E-885C-2164C12BF79C}.Debug|iPhone.ActiveCfg = Debug|Any CPU
311+
{AAE423C4-E9B4-434E-885C-2164C12BF79C}.Debug|iPhone.Build.0 = Debug|Any CPU
312+
{AAE423C4-E9B4-434E-885C-2164C12BF79C}.Debug|iPhoneSimulator.ActiveCfg = Debug|Any CPU
313+
{AAE423C4-E9B4-434E-885C-2164C12BF79C}.Debug|iPhoneSimulator.Build.0 = Debug|Any CPU
314+
{AAE423C4-E9B4-434E-885C-2164C12BF79C}.Debug|x64.ActiveCfg = Debug|Any CPU
315+
{AAE423C4-E9B4-434E-885C-2164C12BF79C}.Debug|x64.Build.0 = Debug|Any CPU
316+
{AAE423C4-E9B4-434E-885C-2164C12BF79C}.Debug|x86.ActiveCfg = Debug|Any CPU
317+
{AAE423C4-E9B4-434E-885C-2164C12BF79C}.Debug|x86.Build.0 = Debug|Any CPU
318+
{AAE423C4-E9B4-434E-885C-2164C12BF79C}.Release|Any CPU.ActiveCfg = Release|Any CPU
319+
{AAE423C4-E9B4-434E-885C-2164C12BF79C}.Release|Any CPU.Build.0 = Release|Any CPU
320+
{AAE423C4-E9B4-434E-885C-2164C12BF79C}.Release|ARM.ActiveCfg = Release|Any CPU
321+
{AAE423C4-E9B4-434E-885C-2164C12BF79C}.Release|ARM.Build.0 = Release|Any CPU
322+
{AAE423C4-E9B4-434E-885C-2164C12BF79C}.Release|iPhone.ActiveCfg = Release|Any CPU
323+
{AAE423C4-E9B4-434E-885C-2164C12BF79C}.Release|iPhone.Build.0 = Release|Any CPU
324+
{AAE423C4-E9B4-434E-885C-2164C12BF79C}.Release|iPhoneSimulator.ActiveCfg = Release|Any CPU
325+
{AAE423C4-E9B4-434E-885C-2164C12BF79C}.Release|iPhoneSimulator.Build.0 = Release|Any CPU
326+
{AAE423C4-E9B4-434E-885C-2164C12BF79C}.Release|x64.ActiveCfg = Release|Any CPU
327+
{AAE423C4-E9B4-434E-885C-2164C12BF79C}.Release|x64.Build.0 = Release|Any CPU
328+
{AAE423C4-E9B4-434E-885C-2164C12BF79C}.Release|x86.ActiveCfg = Release|Any CPU
329+
{AAE423C4-E9B4-434E-885C-2164C12BF79C}.Release|x86.Build.0 = Release|Any CPU
301330
EndGlobalSection
302331
GlobalSection(SolutionProperties) = preSolution
303332
HideSolutionNode = FALSE
304333
EndGlobalSection
305334
GlobalSection(NestedProjects) = preSolution
306335
{54B7812B-45A5-4FE2-9CEA-C5F17D65BDE9} = {47DFE508-04F1-433D-8C55-0C1ACD033573}
336+
{AAE423C4-E9B4-434E-885C-2164C12BF79C} = {47DFE508-04F1-433D-8C55-0C1ACD033573}
307337
EndGlobalSection
308338
GlobalSection(ExtensibilityGlobals) = postSolution
309339
SolutionGuid = {449686DB-B85A-4DFA-AA26-9BC92468CC2A}

0 commit comments

Comments
 (0)