Update Windows guest tool tests

Remove duplicate test_tools_after_reboot which was no longer used.
Reenable upgrade tests.
Add suspend test with emulated NVMe.
Add device ID toggle test.
Add VIF replug test.

Signed-off-by: Tu Dinh <[email protected]>

Author: dinhngtu

tests/guest_tools/win/test_guest_tools_win.py

@@ -1,7 +1,10 @@
 import pytest
 
 import logging
+import time
 
+from lib.commands import SSHCommandFailed
+from lib.common import wait_for
 from lib.vm import VM
 
 from . import PowerAction, wait_for_vm_running_and_ssh_up_without_tools
@@ -59,13 +62,19 @@
 @pytest.mark.multi_vms
 @pytest.mark.usefixtures("windows_vm")
 class TestGuestToolsWindows:
-    def test_tools_after_reboot(self, vm_install_test_tools_per_test_class: VM):
+    def test_drivers_detected(self, vm_install_test_tools_per_test_class: VM):
         vm = vm_install_test_tools_per_test_class
         assert vm.are_windows_tools_working()
 
-    def test_drivers_detected(self, vm_install_test_tools_per_test_class: VM):
+    def test_vif_replug(self, vm_install_test_tools_per_test_class: VM):
         vm = vm_install_test_tools_per_test_class
-        assert vm.are_windows_tools_working()
+        vifs = vm.vifs()
+        for vif in vifs:
+            vif.unplug()
+            # HACK: Allow some time for the unplug to settle. If not, Windows guests have a tendency to explode.
+            time.sleep(5)
+            vif.plug()
+        wait_for(vm.is_ssh_up, "Wait for SSH up")
 
 
 @pytest.mark.multi_vms
@@ -90,9 +99,25 @@ def test_install_with_other_tools(
     ):
         vm, param = vm_install_other_drivers
         if param["upgradable"]:
-            pytest.xfail("Upgrades may require multiple reboots and are not testable yet")
             install_guest_tools(vm, guest_tools_iso, PowerAction.Reboot, check=False)
             assert vm.are_windows_tools_working()
         else:
             exitcode = install_guest_tools(vm, guest_tools_iso, PowerAction.Nothing, check=False)
             assert exitcode == ERROR_INSTALL_FAILURE
+
+    @pytest.mark.usefixtures("uefi_vm")
+    def test_uefi_vm_suspend_refused_without_tools(self, running_unsealed_windows_vm: VM):
+        vm = running_unsealed_windows_vm
+        with pytest.raises(SSHCommandFailed):
+            vm.suspend()
+        wait_for_vm_running_and_ssh_up_without_tools(vm)
+
+    # Test of the unplug rework, where the driver must remain activated even if the device ID changes.
+    # Also serves as a "close-enough" test of vendor device toggling.
+    def test_toggle_device_id(self, running_unsealed_windows_vm: VM, guest_tools_iso: dict[str, Any]):
+        vm = running_unsealed_windows_vm
+        assert vm.param_get("platform", "device_id") == "0002"
+        install_guest_tools(vm, guest_tools_iso, PowerAction.Shutdown, check=False)
+        vm.param_set("platform", "0001", "device_id")
+        vm.start()
+        vm.wait_for_vm_running_and_ssh_up()