Skip to content

Commit 338d76a

Browse files
committed
fix: types error
changed: ordering should be called manually
1 parent 869b050 commit 338d76a

File tree

3 files changed

+2
-6
lines changed

3 files changed

+2
-6
lines changed

phpstan.neon.dist

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@ parameters:
1515
- identifier: binaryOp.invalid
1616
- identifier: return.type
1717
- identifier: argument.type
18+
- identifier: offsetAccess.nonOffsetAccessible
1819

1920
excludePaths:
2021
- ./src/Html/Fluent.php

src/Html/Options/Plugins/ColumnControl.php

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -77,8 +77,7 @@ public function columnControlFooterSearch(array $content = []): static
7777

7878
public function columnControlSearchDropdown(int|string $target = 0): static
7979
{
80-
$this->addColumnControl($target, ['order', 'searchDropdown'])
81-
->ordering(['indicators' => false, 'handler' => false]);
80+
$this->addColumnControl($target, ['order', 'searchDropdown']);
8281

8382
return $this;
8483
}

tests/Html/Extensions/ColumnControlTest.php

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -143,10 +143,6 @@ public function it_can_add_column_control_search_dropdown()
143143
['target' => 1, 'content' => ['order', 'searchDropdown']],
144144
];
145145
$this->assertEquals($expected, $builder->getAttributes()['columnControl']);
146-
147-
// Should also set ordering options
148-
$attributes = $builder->getAttributes();
149-
$this->assertEquals(['indicators' => false, 'handler' => false], $attributes['ordering']);
150146
}
151147

152148
#[Test]

0 commit comments

Comments
 (0)