noticket: Sealed schema exceptions

Co-authored-by: Alexander Lavrukov <[email protected]>

Author: lavrukov

repository-ydb-common/src/main/java/tech/ydb/yoj/repository/ydb/exception/SnapshotCreateException.java

@@ -10,7 +10,7 @@
 @SuppressWarnings("checkstyle:LeftCurly")
 public sealed class YdbRepositoryException
         extends ImplementationSpecificRepositoryException
-        permits ResultTruncatedException, UnexpectedException, SnapshotCreateException, YdbSchemaException
+        permits ResultTruncatedException, UnexpectedException
 {
     public YdbRepositoryException(Object request, Object response) {
         this(null, request, response);

repository-ydb-common/src/main/java/tech/ydb/yoj/repository/ydb/exception/YdbRepositoryException.java

@@ -36,9 +36,9 @@
 import tech.ydb.yoj.repository.db.EntitySchema;
 import tech.ydb.yoj.repository.db.exception.CreateTableException;
 import tech.ydb.yoj.repository.db.exception.DropTableException;
-import tech.ydb.yoj.repository.ydb.exception.SnapshotCreateException;
-import tech.ydb.yoj.repository.ydb.exception.YdbRepositoryException;
-import tech.ydb.yoj.repository.ydb.exception.YdbSchemaPathNotFoundException;
+import tech.ydb.yoj.repository.db.exception.GenericSchemaException;
+import tech.ydb.yoj.repository.db.exception.PathNotFoundException;
+import tech.ydb.yoj.repository.db.exception.SnapshotCreateException;
 import tech.ydb.yoj.repository.ydb.yql.YqlPrimitiveType;
 import tech.ydb.yoj.repository.ydb.yql.YqlType;
 
@@ -336,9 +336,9 @@ private Table describeTableInternal(String path) {
 
         Status status = result.getStatus();
         if (SCHEME_ERROR == status.getCode() && YdbIssue.DEFAULT_ERROR.isContainedIn(status.getIssues())) {
-            throw new YdbSchemaPathNotFoundException(result.toString());
+            throw new PathNotFoundException(result.toString());
         } else if (!result.isSuccess()) {
-            throw new YdbRepositoryException("Can't describe table '" + path + "': " + result);
+            throw new GenericSchemaException("Can't describe table '" + path + "': " + result);
         }
 
         TableDescription table = result.getValue();
@@ -408,7 +408,7 @@ private void removeTablespace(String tablespace) {
         }
     }
 
-    public void snapshot(String snapshotPath) throws SnapshotCreateException {
+    public void snapshot(String snapshotPath) {
         mkdirs(YdbPaths.canonicalRootDir(snapshotPath));
         getTableNames().forEach(tableName -> copyTable(tablespace + tableName, snapshotPath + tableName));
 
@@ -476,7 +476,7 @@ public boolean hasPath(String path) {
             return false;
         }
 
-        throw new YdbRepositoryException("Can't describe table '" + path + "': " + result);
+        throw new GenericSchemaException("Can't describe table '" + path + "': " + result);
     }
 
     @Value

repository-ydb-common/src/main/java/tech/ydb/yoj/repository/ydb/exception/YdbSchemaException.java

@@ -9,16 +9,17 @@
 import tech.ydb.yoj.InternalApi;
 import tech.ydb.yoj.repository.db.exception.DeadlineExceededException;
 import tech.ydb.yoj.repository.db.exception.EntityAlreadyExistsException;
+import tech.ydb.yoj.repository.db.exception.GenericSchemaException;
 import tech.ydb.yoj.repository.db.exception.OptimisticLockException;
 import tech.ydb.yoj.repository.db.exception.QueryCancelledException;
 import tech.ydb.yoj.repository.ydb.exception.BadSessionException;
 import tech.ydb.yoj.repository.ydb.exception.YdbClientInternalException;
 import tech.ydb.yoj.repository.ydb.exception.YdbComponentUnavailableException;
 import tech.ydb.yoj.repository.ydb.exception.YdbOverloadedException;
 import tech.ydb.yoj.repository.ydb.exception.YdbRepositoryException;
-import tech.ydb.yoj.repository.ydb.exception.YdbSchemaException;
 import tech.ydb.yoj.repository.ydb.exception.YdbUnauthenticatedException;
 import tech.ydb.yoj.repository.ydb.exception.YdbUnauthorizedException;
+import tech.ydb.yoj.util.lang.Strings;
 
 import javax.annotation.Nullable;
 import java.util.function.Function;
@@ -120,7 +121,7 @@ public static void validate(String request, StatusCode statusCode, String respon
             }
 
             // Database schema problem, e.g. trying to access a non-existent table, column etc. No retries
-            case SCHEME_ERROR -> throw new YdbSchemaException("Schema error", request, response);
+            case SCHEME_ERROR -> throw new GenericSchemaException(Strings.join("\n", "Schema error", request, response));
 
             // Serious internal error. No retries
             case CLIENT_CALL_UNIMPLEMENTED,

repository-ydb-common/src/main/java/tech/ydb/yoj/repository/ydb/exception/YdbSchemaPathNotFoundException.java

@@ -13,9 +13,9 @@
 import tech.ydb.yoj.repository.db.StdTxManager;
 import tech.ydb.yoj.repository.db.Tx;
 import tech.ydb.yoj.repository.db.TxManager;
+import tech.ydb.yoj.repository.db.exception.SchemaException;
 import tech.ydb.yoj.repository.db.readtable.ReadTableParams;
 import tech.ydb.yoj.repository.ydb.YdbRepository;
-import tech.ydb.yoj.repository.ydb.exception.YdbSchemaException;
 
 import java.time.Duration;
 import java.util.List;
@@ -63,7 +63,7 @@ public void run() {
                 });
             } catch (Exception e) {
                 String message = format("[%s] Got exception while checking entities of %s: ", sw, ec.getSimpleName());
-                if (config.skipSchemaErrors && e instanceof YdbSchemaException) {
+                if (config.skipSchemaErrors && e instanceof SchemaException) {
                     log.warn(message);
                 } else {
                     log.error(message);

repository-ydb-v2/src/main/java/tech/ydb/yoj/repository/ydb/client/YdbSchemaOperations.java

@@ -1,6 +1,6 @@
 package tech.ydb.yoj.repository.db.exception;
 
-public final class CreateTableException extends RepositoryException {
+public final class CreateTableException extends SchemaException {
     public CreateTableException(String msg) {
         super(msg);
     }

repository-ydb-v2/src/main/java/tech/ydb/yoj/repository/ydb/client/YdbValidator.java

@@ -1,6 +1,6 @@
 package tech.ydb.yoj.repository.db.exception;
 
-public final class DropTableException extends RepositoryException {
+public final class DropTableException extends SchemaException {
     public DropTableException(String msg) {
         super(msg);
     }

repository-ydb-v2/src/main/java/tech/ydb/yoj/repository/ydb/compatibility/YdbDataCompatibilityChecker.java

@@ -0,0 +1,7 @@
+package tech.ydb.yoj.repository.db.exception;
+
+public final class GenericSchemaException extends SchemaException {
+    public GenericSchemaException(String message) {
+        super(message);
+    }
+}