Skip to content

Commit 37bb91e

Browse files
lentitude2tklikun
authored andcommitted
add shardNum field if listCollection (milvus-io#1585)
Signed-off-by: lentitude2tk <[email protected]>
1 parent 3702c08 commit 37bb91e

File tree

3 files changed

+29
-5
lines changed

3 files changed

+29
-5
lines changed
Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,11 @@
1+
package io.milvus.v2.service.collection;
2+
3+
import lombok.Data;
4+
import lombok.experimental.SuperBuilder;
5+
6+
@Data
7+
@SuperBuilder
8+
public class CollectionInfo {
9+
private String collectionName;
10+
private Integer shardNum;
11+
}

sdk-core/src/main/java/io/milvus/v2/service/collection/CollectionService.java

Lines changed: 16 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -183,11 +183,24 @@ public ListCollectionsResp listCollections(MilvusServiceGrpc.MilvusServiceBlocki
183183
ShowCollectionsRequest showCollectionsRequest = ShowCollectionsRequest.newBuilder()
184184
.build();
185185
ShowCollectionsResponse response = blockingStub.showCollections(showCollectionsRequest);
186-
ListCollectionsResp listCollectionsResp = ListCollectionsResp.builder()
186+
187+
List<CollectionInfo> collectionInfos = new ArrayList<>();
188+
for (int i = 0; i < response.getCollectionNamesCount(); i++) {
189+
CollectionInfo collectionInfo = CollectionInfo.builder()
190+
.collectionName(response.getCollectionNames(i))
191+
.build();
192+
// Milvus version >= 2.6.1 will additionally return shardNum
193+
List<Integer> shardsNums = response.getShardsNumList();
194+
if (CollectionUtils.isNotEmpty(shardsNums)) {
195+
collectionInfo.setShardNum(response.getShardsNum(i));
196+
}
197+
collectionInfos.add(collectionInfo);
198+
}
199+
200+
return ListCollectionsResp.builder()
187201
.collectionNames(response.getCollectionNamesList())
202+
.collectionInfos(collectionInfos)
188203
.build();
189-
190-
return listCollectionsResp;
191204
}
192205

193206
public Void dropCollection(MilvusServiceGrpc.MilvusServiceBlockingStub blockingStub, DropCollectionReq request) {

sdk-core/src/main/java/io/milvus/v2/service/collection/response/ListCollectionsResp.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -50,9 +50,9 @@ public void setCollectionNames(List<String> collectionNames) {
5050
public boolean equals(Object obj) {
5151
if (this == obj) return true;
5252
if (obj == null || getClass() != obj.getClass()) return false;
53-
53+
5454
ListCollectionsResp that = (ListCollectionsResp) obj;
55-
55+
5656
return new EqualsBuilder()
5757
.append(collectionNames, that.collectionNames)
5858
.isEquals();

0 commit comments

Comments
 (0)