Update yahoo.finance.analystestimate.xml to new HTML structure #449
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
berndsi
changed the title
This was referenced Apr 21, 2016
|
Any chances to merge this one so that we can restore a proper yql data retrieval for analystestimates? |
|
It seems like actually, it doesn't work anymore as there are no yfnc_tableout1 classes for tables. @berndsi Could you make a review for this table? |
|
@4eetah I don't work for Yahoo, and I'm pretty confident I don't have permission to merge this myself. Also, this PR is pretty old. I'm not sure if there are more changes necessary. I haven't used it in a long time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The HTML structure in several finance.yahoo.com outputs has changed a couple of weeks ago,
which broke the YQL table implementations.
This PR updates parsing of analystestimate HTML output via YQL.