Skip to content

Commit 1f00cae

Browse files
committed
Update logging messages
1 parent 3f0d477 commit 1f00cae

File tree

2 files changed

+15
-6
lines changed

2 files changed

+15
-6
lines changed

SerialDisk/Common/Constants.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ public static Dictionary<string, string> ConsoleParameterMappings
2121
{ "--disk-size", "DiskSettings:DiskSizeMiB" },
2222
{ "--tos-version", "DiskSettings:DiskTOSCompatibility" },
2323
{ "--root-directory-sectors", "DiskSettings:RootDirectorySectors" },
24-
{ "--data-compression", "CompressionIsEnabled" },
24+
{ "--compression", "CompressionIsEnabled" },
2525

2626
{ "--port", "SerialSettings:PortName" },
2727
{ "--baud-rate", "SerialSettings:BaudRate" },

SerialDisk/Comms/Serial.cs

Lines changed: 14 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -370,10 +370,9 @@ private void SendData()
370370
_logger.Log("Sending data...", LoggingLevel.Verbose);
371371

372372
if (_receivedSectorCount == 1)
373-
_logger.Log("Reading sector " + _receivedSectorIndex + " (" + _localDisk.Parameters.BytesPerSector + " Bytes)... ", LoggingLevel.Info);
373+
_logger.Log("Reading sector " + _receivedSectorIndex, LoggingLevel.Info);
374374
else
375-
_logger.Log("Reading sectors " + _receivedSectorIndex + " - " + (_receivedSectorIndex + _receivedSectorCount - 1) + " (" + (_receivedSectorCount * _localDisk.Parameters.BytesPerSector) + " Bytes)... ", LoggingLevel.Info);
376-
375+
_logger.Log("Reading sectors " + _receivedSectorIndex + " - " + (_receivedSectorIndex + _receivedSectorCount - 1), LoggingLevel.Info);
377376

378377
byte[] sendDataBuffer = _localDisk.ReadSectors((int)_receivedSectorIndex, (int)_receivedSectorCount);
379378

@@ -383,13 +382,19 @@ private void SendData()
383382

384383
if(_compressionIsEnabled) serialFlags |= _serialFlags.compression;
385384

386-
_logger.Log($"Sending data flags: {serialFlags.ToString()}...", LoggingLevel.Verbose);
385+
_logger.Log($"Sending serial flags: {serialFlags.ToString()}...", LoggingLevel.Verbose);
387386
_serialPort.BaseStream.WriteByte(Convert.ToByte(serialFlags));
388387

388+
var numUncompressedBytes = sendDataBuffer.Length;
389+
390+
string sendingMessage = $"Sending {numUncompressedBytes} bytes";
391+
389392
if (serialFlags.HasFlag(_serialFlags.compression))
390393
{
391394
sendDataBuffer = Utilities.LZ4.CompressAsStandardLZ4Block(sendDataBuffer);
392395

396+
sendingMessage = $"Sending {sendDataBuffer.Length} bytes";
397+
393398
_transferStartDateTime = DateTime.Now;
394399

395400
byte[] dataLenBuffer = new byte[4];
@@ -398,11 +403,15 @@ private void SendData()
398403
dataLenBuffer[2] = (byte)((sendDataBuffer.Length >> 8) & 0xff);
399404
dataLenBuffer[3] = (byte)(sendDataBuffer.Length & 0xff);
400405

401-
_logger.Log($"Sending compressed data ({sendDataBuffer.Length} bytes)...", LoggingLevel.Verbose);
406+
float percentageOfOriginalSize = (100 / (float)numUncompressedBytes) * sendDataBuffer.Length;
407+
408+
_logger.Log($"Compression: { percentageOfOriginalSize.ToString("00.0")}% of { numUncompressedBytes} bytes", LoggingLevel.Verbose);
402409

403410
_serialPort.BaseStream.Write(dataLenBuffer, 0, dataLenBuffer.Length);
404411
}
405412

413+
_logger.Log(sendingMessage, LoggingLevel.Info);
414+
406415
for (int i = 0; i < sendDataBuffer.Length; i++)
407416
{
408417
_serialPort.BaseStream.WriteByte(sendDataBuffer[i]);

0 commit comments

Comments
 (0)