symfony 4.2.9 fires entered event on initialize

Author: Zack Teska

composer.json

@@ -5,7 +5,7 @@
     "license": "MIT",
     "require": {
         "php": ">=7.2",
-        "symfony/workflow": "^4.2",
+        "symfony/workflow": "^4.2.9",
         "symfony/process": "^4.2",
         "symfony/event-dispatcher": "^4.2",
         "illuminate/console": "5.3.* || 5.4.* || 5.5.* || 5.6.* || 5.7.* || 5.8.*",

src/Events/WorkflowSubscriber.php

@@ -13,7 +13,7 @@ class WorkflowSubscriber implements EventSubscriberInterface
 {
     public function guardEvent(SymfonyGuardEvent $event)
     {
-        $workflowName   = $event->getWorkflowName();
+        $workflowName = $event->getWorkflowName();
         $transitionName = $event->getTransition()->getName();
 
         event(new GuardEvent($event));
@@ -24,7 +24,7 @@ public function guardEvent(SymfonyGuardEvent $event)
 
     public function leaveEvent(Event $event)
     {
-        $places       = $event->getTransition()->getFroms();
+        $places = $event->getTransition()->getFroms();
         $workflowName = $event->getWorkflowName();
 
         event(new LeaveEvent($event));
@@ -38,7 +38,7 @@ public function leaveEvent(Event $event)
 
     public function transitionEvent(Event $event)
     {
-        $workflowName   = $event->getWorkflowName();
+        $workflowName = $event->getWorkflowName();
         $transitionName = $event->getTransition()->getName();
 
         event(new TransitionEvent($event));
@@ -49,7 +49,7 @@ public function transitionEvent(Event $event)
 
     public function enterEvent(Event $event)
     {
-        $places       = $event->getTransition()->getTos();
+        $places = $event->getTransition()->getTos();
         $workflowName = $event->getWorkflowName();
 
         event(new EnterEvent($event));
@@ -63,7 +63,7 @@ public function enterEvent(Event $event)
 
     public function enteredEvent(Event $event)
     {
-        $places       = $event->getTransition()->getTos();
+        $places = $event->getTransition() ? $event->getTransition()->getTos() : [];
         $workflowName = $event->getWorkflowName();
 
         event(new EnteredEvent($event));

tests/WorkflowSubscriberTest.php

@@ -44,42 +44,47 @@ public function testIfWorkflowEmitsEvents()
 
             $workflow->apply($object, 't1');
 
-            $this->assertCount(28, $events);
-
-            $this->assertInstanceOf(GuardEvent::class, $events[0]);
-            $this->assertEquals('workflow.guard', $events[1]);
-            $this->assertEquals('workflow.straight.guard', $events[2]);
-            $this->assertEquals('workflow.straight.guard.t1', $events[3]);
-
-            $this->assertInstanceOf(LeaveEvent::class, $events[4]);
-            $this->assertEquals('workflow.leave', $events[5]);
-            $this->assertEquals('workflow.straight.leave', $events[6]);
-            $this->assertEquals('workflow.straight.leave.a', $events[7]);
-
-            $this->assertInstanceOf(TransitionEvent::class, $events[8]);
-            $this->assertEquals('workflow.transition', $events[9]);
-            $this->assertEquals('workflow.straight.transition', $events[10]);
-            $this->assertEquals('workflow.straight.transition.t1', $events[11]);
-
-            $this->assertInstanceOf(EnterEvent::class, $events[12]);
-            $this->assertEquals('workflow.enter', $events[13]);
-            $this->assertEquals('workflow.straight.enter', $events[14]);
-            $this->assertEquals('workflow.straight.enter.b', $events[15]);
-
-            $this->assertInstanceOf(EnteredEvent::class, $events[16]);
-            $this->assertEquals('workflow.entered', $events[17]);
-            $this->assertEquals('workflow.straight.entered', $events[18]);
-            $this->assertEquals('workflow.straight.entered.b', $events[19]);
-
-            $this->assertInstanceOf(CompletedEvent::class, $events[20]);
-            $this->assertEquals('workflow.completed', $events[21]);
-            $this->assertEquals('workflow.straight.completed', $events[22]);
-            $this->assertEquals('workflow.straight.completed.t1', $events[23]);
-
-            $this->assertInstanceOf(GuardEvent::class, $events[24]);
-            $this->assertEquals('workflow.guard', $events[25]);
-            $this->assertEquals('workflow.straight.guard', $events[26]);
-            $this->assertEquals('workflow.straight.guard.t2', $events[27]);
+            $this->assertCount(31, $events);
+
+            // Symfony Workflow 4.2.9 fires entered event on initialize
+            $this->assertInstanceOf(EnteredEvent::class, $events[0]);
+            $this->assertEquals('workflow.entered', $events[1]);
+            $this->assertEquals('workflow.straight.entered', $events[2]);
+
+            $this->assertInstanceOf(GuardEvent::class, $events[3]);
+            $this->assertEquals('workflow.guard', $events[4]);
+            $this->assertEquals('workflow.straight.guard', $events[5]);
+            $this->assertEquals('workflow.straight.guard.t1', $events[6]);
+
+            $this->assertInstanceOf(LeaveEvent::class, $events[7]);
+            $this->assertEquals('workflow.leave', $events[8]);
+            $this->assertEquals('workflow.straight.leave', $events[9]);
+            $this->assertEquals('workflow.straight.leave.a', $events[10]);
+
+            $this->assertInstanceOf(TransitionEvent::class, $events[11]);
+            $this->assertEquals('workflow.transition', $events[12]);
+            $this->assertEquals('workflow.straight.transition', $events[13]);
+            $this->assertEquals('workflow.straight.transition.t1', $events[14]);
+
+            $this->assertInstanceOf(EnterEvent::class, $events[15]);
+            $this->assertEquals('workflow.enter', $events[16]);
+            $this->assertEquals('workflow.straight.enter', $events[17]);
+            $this->assertEquals('workflow.straight.enter.b', $events[18]);
+
+            $this->assertInstanceOf(EnteredEvent::class, $events[19]);
+            $this->assertEquals('workflow.entered', $events[20]);
+            $this->assertEquals('workflow.straight.entered', $events[21]);
+            $this->assertEquals('workflow.straight.entered.b', $events[22]);
+
+            $this->assertInstanceOf(CompletedEvent::class, $events[23]);
+            $this->assertEquals('workflow.completed', $events[24]);
+            $this->assertEquals('workflow.straight.completed', $events[25]);
+            $this->assertEquals('workflow.straight.completed.t1', $events[26]);
+
+            $this->assertInstanceOf(GuardEvent::class, $events[27]);
+            $this->assertEquals('workflow.guard', $events[28]);
+            $this->assertEquals('workflow.straight.guard', $events[29]);
+            $this->assertEquals('workflow.straight.guard.t2', $events[30]);
         }
     }
 }