-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
Child.start_suspended ported to posix #25820
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Following up the comment in the review, I can add |
|
See #24027. Perhaps you can revive that one since the author hasn't responded to my review comments yet. |
|
I've used But please note that |
alexrp
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
For the sake of clean history, can you squash this into two commits:
- The addition of
getpidandgetppidtostd.posix - The implementation of POSIX
start_suspendedsupport instd.process.Child
d82eecb to
f4159ef
Compare
|
Thanks! |
This patch ports
Child.start_suspendedto Linux.Note: The doc-comment says that
start_suspendedis implemented for Darwin but giving a quick look to the file I can't find where this is achieved.