Skip to content

zaino-common uncontrollably depends on zingo-infra-services #541

New issue
New issue
Open
#565
Open
zaino-common uncontrollably depends on zingo-infra-services#541
#565
Assignees
zancasfluidvanadium
@str4d

Description

@str4d
str4d
opened on Sep 17, 2025

The only thing the dependency is used for in zaino-common is to implement a conversion between Network types:

zaino/zaino-common/src/network.rs

Lines 192 to 212 in 528ef7d

impl From<Network> for zingo_infra_services::network::Network {
fn from(val: Network) -> Self {
match val {
Network::Mainnet => zingo_infra_services::network::Network::Mainnet,
Network::Regtest(_) => zingo_infra_services::network::Network::Regtest,
Network::Testnet => zingo_infra_services::network::Network::Testnet,
}
}
}
impl From<zingo_infra_services::network::Network> for Network {
fn from(value: zingo_infra_services::network::Network) -> Self {
match value {
zingo_infra_services::network::Network::Regtest => {
Network::Regtest(ActivationHeights::default())
}
zingo_infra_services::network::Network::Testnet => Network::Testnet,
zingo_infra_services::network::Network::Mainnet => Network::Mainnet,
}
}
}

However, this causes the entirety of zingo-infra-services to be pulled into downstreams like Zallet, including all of its diverging zcash_* crate versions as well as (currently) a dependency on OpenSSL that we will not accept.

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions