Refurbish indexerconfig follow-ups

[ala-mode]

Placeholder issue for loose ends from #571 - could be split into multiple issues, or discussed here.
I am putting links on dev to point out issues independent of #571 changes.
Changes I am taking on I'll mark as WIP and attach PR #s to them here.

= DONE =

• Building directly on top of Refurbish indexerconfig #571

create_test_manager_and_fetch_services(...)

zaino/integration-tests/tests/json_server.rs

Line 14 in 7936029

async fn create_test_manager_and_fetch_services(

has many (17) references, in which enable_cookie_auth is ALWAYS false.

= REPORTING =

• zaino/zaino-testutils/src/lib.rs

  Line 579 in 7936029

  enable_zaino_jsonrpc_server: bool,

  
  launch_with_default_activation_heights(...)
  is eliminated in Refurbish indexerconfig #571 but launch(...) still has this same argument from Validator config:
  enable_zaino_jsonrpc_server_cookie_auth: bool,
  This is false in all but one reference, but I could not eliminate it easily because it is used within launch() to spawn the indexer (Zainod):
  

  zaino/zaino-testutils/src/lib.rs

  Line 506 in 7936029

  let handle = zainodlib::indexer::spawn_indexer(indexer_config)

  
  

  zaino/zaino-testutils/src/lib.rs

  Line 475 in 7936029

  let indexer_config = zainodlib::config::IndexerConfig {

= To Triage or Discuss =

• Config: Ambiguous cookie file setting #645

=

• update zindexer.toml #663

=

• (

  zaino/zaino-testutils/src/lib.rs

  Line 184 in 7936029

  LocalNet::Zcashd(net) => net.validator().get_activation_heights(),

  )
  many of these matches could be less verbose, perhaps by defining a into-inner kind of function?

=

• for example here
  

  zaino/zaino-testutils/src/lib.rs

  Line 461 in 7936029

  zaino_grpc_listen_address,

  
  ... there is some mismatch between JsonRpcServerConfig/JsonRpcServer and GrpcConfig/GrpcServer structs.

=

• Split up launch() function #665
  =

• is impl GrpcServerConfig redundant? #664

=

• (

  zaino/zaino-state/src/config.rs

  Line 117 in 7936029

  impl FetchServiceConfig {

  )
  should this live in another module?
  pub struct FetchServiceConfig { ...

=

• (

  zaino/zainod/tests/config.rs

  Line 182 in 7936029

  jail.create_file(

  )
  I'm not sure if they are needed but I don't see any analog to these for gRPC config as well.

[ala-mode]

In the last few commits to #571, in /zaino-testutils/src/lib.rs I removed unused logic that set
zaino_json_server_cookie_dir = Some(default_ephemeral_cookie_path());
Therefore, I think there are no tests that pass through the launch() function there that test this functionality (assigning a default ephemeral cookie path).

[ala-mode]

• see Config follow up: unused var #646

[ala-mode]

@zancas I'm asking for you to look at this as it seems like you were involved in the updating, review and subsequent merge of #571 . These are what I saw as 'loose ends'. Probably many of these could be addressed fairly quickly, maybe others might take more time.

[dorianvp]

Can we split this into sub-issues?

[ala-mode]

I'll plan to split this up.

[ala-mode]

... this functionality (assigning a default ephemeral cookie path).

In chat it was mentioned we may not be using defaults (non-user-specified config variables), so this may be outdated, soon.

[ala-mode]

I tried to shrink "many of these matches could be less verbose, perhaps by defining a into-inner kind of function?" but due to the typing I'm not sure this could be done, at least without an equally verbose or confusing trait scheme.

[ala-mode]

Of the remaining items, I think refactoring launch into smaller pieces #665 might benefit hackability, and #645 particularly I was wishing other devs would look at.