helm: make explicit that image tags are set by chartpress #57
+6
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey all! Thank you for your work on this project!!
I look to deploy it, and as part of that I wanted to learn more how it works. Doing that I found references to image tags versioned
0.0.7, but later realized they were set by chartpress before the chart was published. I think if the tag had been "set-by-chartpress" instead, it could add some clarity at least for me who could conclude from that that: images were maintained in this repo, and images were kept up to date and not outdated.This PR therefore proposes to declare
set-by-chartpressas default value instead of the currently outdated version.set-by-chartpressit is what you get if you dochartpress --resetby default.Btw I appreciated the readme, the changelog, and the docstring of generate.py a lot when learning about this project - thank you!