Skip to content

Fix video and model viewer #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Fix video and model viewer #6

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
720bfd9
Add release-please.
nicolas-daures Feb 7, 2024
a03f004
fix: use poster when video has not been launched
nicolas-daures Feb 7, 2024
5836dd2
fix: use childNodes from the Slot tag if there are no assignedNodes.
nicolas-daures Feb 7, 2024
f3c5d9e
fix: use poster only if there is one
nicolas-daures Feb 7, 2024
d565695
Bump version to 1.11.11-2
nicolas-daures Feb 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions .github/workflows/release-please.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
on:
push:
branches:
- main

permissions:
contents: write
pull-requests: write

name: release-please

jobs:
release-please:
runs-on: ubuntu-latest
steps:
- uses: google-github-actions/release-please-action@v4
with:
token: ${{ secrets.GITHUB_TOKEN }}
release-type: node
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "html-to-image-mod",
"version": "1.11.11-1",
"version": "1.11.11-2",
"description": "Generates an image from a DOM node using HTML5 canvas and SVG. This is a fork which fixes #345 from original Repo (bubkoo/html-to-image) ",
"main": "lib/index.js",
"module": "es/index.js",
Expand Down
4 changes: 2 additions & 2 deletions src/clone-node.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ async function cloneCanvasElement(canvas: HTMLCanvasElement) {
}

async function cloneVideoElement(video: HTMLVideoElement, options: Options) {
if (video.currentSrc) {
if (video.currentSrc && (video.poster == null || video.poster === '' || video.currentTime > 0)) {
const canvas = document.createElement('canvas')
const ctx = canvas.getContext('2d')
canvas.width = video.clientWidth
Expand Down Expand Up @@ -74,7 +74,7 @@ async function cloneChildren<T extends HTMLElement>(
): Promise<T> {
let children: T[] = []

if (isSlotElement(nativeNode) && nativeNode.assignedNodes) {
if (isSlotElement(nativeNode) && nativeNode.assignedNodes && nativeNode.assignedNodes().length > 0) {
children = toArray<T>(nativeNode.assignedNodes())
} else if (
isInstanceOfElement(nativeNode, HTMLIFrameElement) &&
Expand Down