Skip to content

Conversation

jmcarcell
Copy link
Member

BEGINRELEASENOTES

  • Modernize code related to Surfaces and the SurfaceManager. Simplify for loops, define default destructors with =default, pass arguments by const reference when possible
  • Make DetectorSurfaces not inherit from DetElement since it is not used nor needed

ENDRELEASENOTES

Make DetectorSurfaces not inherit from DetElement, use range-based for loops,
pass arguments by const reference when possible, initialize class members
Copy link

github-actions bot commented Sep 9, 2025

Test Results

   18 files     18 suites   6h 6m 54s ⏱️
  372 tests   372 ✅ 0 💤 0 ❌
3 278 runs  3 278 ✅ 0 💤 0 ❌

Results for commit f8c0305.

@andresailer
Copy link
Member

Hi @MarkusFrankATcernch

Could you have a look at these changes? Any reason things were the way they were and shouldn't be changed?

@MarkusFrankATcernch
Copy link
Contributor

MarkusFrankATcernch commented Oct 3, 2025

@andresailer
Short answer:no idea, Frank should know ;-)

Longer answer:
I do not know why DetectorSurfaces have to be a DetElement. I think this is the main question.
If this is-a-relagtionship is not mandatory, then the changes of Juan are all correct.
If DetectorSurfaces have to be a DetElement then not.
The fact that all DD4hep and ILC tests work is a hint that this inheritance is not necessary.

@gaede : do you remember why this relationship was introduced?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants