Skip to content

Conversation

tmadlener
Copy link
Contributor

@tmadlener tmadlener commented Sep 10, 2025

BEGINRELEASENOTES

ENDRELEASENOTES

Keeping this as draft for now, until we have finalized all the details upstream, but I think those should be largely transparent for these changes.

Copy link

github-actions bot commented Sep 10, 2025

Test Results

   18 files     18 suites   7h 0m 42s ⏱️
  372 tests   372 ✅ 0 💤 0 ❌
3 278 runs  3 278 ✅ 0 💤 0 ❌

Results for commit 2ac7695.

♻️ This comment has been updated with latest results.

@tmadlener
Copy link
Contributor Author

I realized that the ingestion of the GeneratorEventParameters was tied to the presence of an EventHeader, which shouldn't be the case. I have also added pre-processor version checks for EDM4hep to make CI pass for older EDM4hep versions.

@tmadlener tmadlener force-pushed the edm4hep-gen-evt-parameters branch from cdbfb6e to 50ac15f Compare September 11, 2025 07:37
@tmadlener tmadlener marked this pull request as ready for review October 2, 2025 13:33
@tmadlener tmadlener force-pushed the edm4hep-gen-evt-parameters branch from 50ac15f to d64d313 Compare October 2, 2025 13:33
@tmadlener tmadlener force-pushed the edm4hep-gen-evt-parameters branch from d64d313 to 47615eb Compare October 7, 2025 14:21
Co-authored-by: Andre Sailer <[email protected]>
@andresailer andresailer merged commit 3215055 into AIDASoft:master Oct 8, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add GeneratorInfo to EDM4hepReader

2 participants