Improve error messages when readers encounter problems #851
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmadlener
force-pushed
the
detect-too-new-dm
branch
from
40c99e2 to
1c02d64
Compare
tmadlener
commented
Sep 29, 2025
Comment on lines
+26
to
+30
| if (!envSchemaVersion) { | ||
| warnings.emplace_back("EDM '" + edmName + | ||
| "' exists in file but does not seem to be loaded from the environment by podio"); | ||
| continue; | ||
| } |
There was a problem hiding this comment.
This might emit warnings that are harmless. E.g. RNTuple seems to be much less eager to pull in EDM libraries if they are not needed but they might still be present in the file. It looks like it does a much lazier loading than the TTree version, so that this check is potentially too early. But it really isn't clear to me why it would know at this point which libraries it has to load.
I have to check what is going on here and why RNTuple seems to behave special here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BEGINRELEASENOTES
ROOTReaderin case collection buffers cannot be constructed for a given type and schema versionROOTReaderreturn anullptrROOTFrameDatain case a non-readable collection is encountered instead of letting thestd::bad_function_callescape fromreadEntry.ENDRELEASENOTES
Fixes #848, Fixes #847