Skip to content

Conversation

EZoni
Copy link
Member

@EZoni EZoni commented Sep 9, 2025

Requested by @ax3l on Slack (to be used in #378):

Do you mind adding the Tools/Release/update_dependencies.py script (simply in /) to pyAMReX, too? Do not need the other automations for now.

WarpX references:

To-do:

  • AMReX
  • pybind11

@EZoni EZoni force-pushed the update_dependencies branch from ad8b14e to db23d6e Compare September 10, 2025 22:31
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Down the road it would be nice if we found a way to make this a BLAST-level module, since a lot of code is shared with the WarpX script.

@EZoni EZoni changed the title [WIP] Implement same dependency/release update workflow as WarpX Implement same dependency/release update workflow as WarpX Sep 10, 2025
ax3l pushed a commit to BLAST-WarpX/warpx that referenced this pull request Sep 16, 2025
Fix a minor bug that I found while testing the same tool in
AMReX-Codes/pyamrex#474.
Copy link
Member

@ax3l ax3l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need to include dependencies.json in MANIFEST.in, otherwise PyPI source packages (uncompiled) will lack the file and CMake builds from pip source packages will fail.

@ax3l
Copy link
Member

ax3l commented Sep 16, 2025

I'll add it and post a fix to WarpX, too

@ax3l ax3l mentioned this pull request Sep 16, 2025
2 tasks
Copy link
Member

@ax3l ax3l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! :)

@ax3l ax3l enabled auto-merge (squash) September 16, 2025 23:14
@ax3l ax3l merged commit a1d7a94 into AMReX-Codes:development Sep 17, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants