-
Notifications
You must be signed in to change notification settings - Fork 22
Implement same dependency/release update workflow as WarpX #474
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
1aa978a
to
ad8b14e
Compare
ad8b14e
to
db23d6e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Down the road it would be nice if we found a way to make this a BLAST-level module, since a lot of code is shared with the WarpX script.
Fix a minor bug that I found while testing the same tool in AMReX-Codes/pyamrex#474.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we need to include dependencies.json
in MANIFEST.in
, otherwise PyPI
source packages (uncompiled) will lack the file and CMake builds from pip source packages will fail.
I'll add it and post a fix to WarpX, too |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! :)
Requested by @ax3l on Slack (to be used in #378):
WarpX references:
To-do: