Fix CMake typo in python module build type check on Apple #136
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ted Waine <[email protected]>
…Foundation/tedwaine-patch-1 Update issue templates
Signed-off-by: Ted Waine <[email protected]>
…-template Adding pull request template
Signed-off-by: Ted Waine <[email protected]>
…plate-tweak Tweak PR template
Signed-off-by: Ted Waine <[email protected]>
…p-v1 Version 1.0.0 alpha
Signed-off-by: Ted Waine <[email protected]>
…p-v1 Attempt to add OTIO as submodule
Signed-off-by: jijamik <[email protected]>
The committers listed above are authorized under a signed CLA. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summarize your change.
Corrected a typo in the CMake variable
CMAKE__BUILD_TYPEto the correctCMAKE_BUILD_TYPEwithin thesrc/python_module/src/CMakeLists.txtfile.Describe what you have tested and on which operating system.
Verified that it build successfully without the previously mentioned error after applying this change. Tested on macOS
Add a list of changes, and note any that might need special attention during the review.
src/python_module/src/CMakeLists.txtif (${CMAKE__BUILD_TYPE} STREQUAL "Debug")if (${CMAKE_BUILD_TYPE} STREQUAL "Debug")This is a straightforward typo correction and should not require special attention beyond verifying the variable name is now correct.