Skip to content

Nara #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Nara #27

wants to merge 1 commit into from

Conversation

bonara
Copy link

@bonara bonara commented Aug 27, 2019

No description provided.

CheezItMan
CheezItMan reviewed Sep 3, 2019
View reviewed changes
Copy link

@CheezItMan CheezItMan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You hit most the learning goals here. Well done. Check out my comments and let me know if you have any questions.

lib/linked_list.rb

# method that returns the value of the last node in the linked list
# returns nil if the linked list is empty
# Time Complexity:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Space and time complexity?

lib/linked_list.rb
while current
current = current.next
end
return current.data
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What if @head is nil?

lib/linked_list.rb
end

# method that inserts a given value as a new last node in the linked list
# Time Complexity:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

space & time?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CheezItMan CheezItMan CheezItMan left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bonara @CheezItMan