-
Notifications
You must be signed in to change notification settings - Fork 50
Leaves - Samantha #30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Changes from all commits
58fb4f7
187449c
2affa00
b8f58f8
8a6014a
abca782
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -9,6 +9,7 @@ const presets = [ | |
| safari: "11.1", | ||
| }, | ||
| useBuiltIns: "usage", | ||
| corejs: 2, | ||
| }, | ||
| ], | ||
| ]; | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,8 +1,68 @@ | ||
| const Adagrams = { | ||
| drawLetters() { | ||
| // Implement this method for wave 1 | ||
| const alphabet = 'AAAAAAAAABBCCDDDDEEEEEEEEEEEEFFGGGHHIJKLLLLMMNNNNNNOOOOOOOOPPQRRRRRRSSSSTTTTTTUUUUVVWWXYYZ'; | ||
| const lettersInHand = []; | ||
|
|
||
| for (let i = 0; i < 10; i++) { | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. There's a small bug here. Consider how you could make sure you don't pick the same letter 10 times (however unlikely it is). |
||
| lettersInHand.push(alphabet.charAt(Math.floor(Math.random() * alphabet.length))); | ||
| } | ||
| return lettersInHand; | ||
| }, | ||
|
|
||
| usesAvailableLetters(input, lettersInHand) { | ||
| let result = true; | ||
|
|
||
| for (let i = 0; i < (input.length); i++) { | ||
| if (lettersInHand.includes(input[i]) === false) { | ||
| result = false; | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. since you used a traditional for loop you could simply |
||
| } else { | ||
| lettersInHand.splice(lettersInHand.indexOf(input[i]), 1); | ||
| } | ||
| } | ||
| return result; | ||
| }, | ||
|
|
||
| scoreWord(word) { | ||
| const score = { A:1, E:1, I:1, O:1, U:1, L:1, N:1, R:1, S:1, T:1, D:2, G:2, | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. style note: put each key-value pair on one line. |
||
| B:3, C:3, M:3, P:3, F:4, H:4, V:4, W:4, Y:4, K:5, J:8, X:8, Q:10, Z:10 }; | ||
|
|
||
| let points = 0; | ||
| const wordCheck = word.toUpperCase(); | ||
|
|
||
| if (wordCheck.length > 6) { | ||
| points += 8; | ||
| } | ||
|
|
||
| for (let i = 0; i < (wordCheck.length); i++) { | ||
| points += score[wordCheck[i]]; | ||
| } | ||
| return points; | ||
| }, | ||
|
|
||
| highestScoreFrom(words) { | ||
| let scores = []; | ||
|
|
||
| //Loops through the array of words and calling the method scoreWords to get the scores | ||
| for (let i = 0; i < (words.length); i++) { | ||
| scores.push(Adagrams.scoreWord(words[i])); | ||
| } | ||
|
|
||
| // The Math.max.apply(null, array) finds the max value on the array scores | ||
| // The function indexOf finds the value for the index with the max value | ||
| let correct = { word: words[scores.indexOf(Math.max.apply(null, scores))], score: Math.max.apply(null, scores) }; | ||
|
|
||
| // Still need to work on the tie-breaking rules for Wave 4: | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. You've got a good start! |
||
| return correct; | ||
| }, | ||
| }; | ||
|
|
||
|
|
||
| // I ran each function bewlow and tested also on the console to troubleshoot failing tests etc. | ||
| // console.log(Adagrams.highestScoreFrom(["APPLE", "BLUE", "PIE"])) | ||
| // console.log(Adagrams.drawLetters()); | ||
| // console.log(Adagrams.usesAvailableLetters('APPLE', ['A', 'P', 'P', 'L', 'E'])); | ||
| // console.log(Adagrams.usesAvailableLetters('APPLES', ['A', 'P', 'P', 'L', 'E'])); | ||
| // console.log(Adagrams.scoreWord('AVAILABLE')) | ||
|
|
||
| // Do not remove this line or your tests will break! | ||
| export default Adagrams; | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This data structure works, but it's not very DRY and would be tricky to change. For example, suppose I said you had the wrong number of "I"s - you would have to do a lot of counting to solve the problem.
Instead you might store a hash of letter frequencies like this