Leaves - Elizabeth #43
Conversation
JS AdagramsWhat We're Looking For
|
| @@ -1,7 +1,104 @@ | |||
| const Adagrams = { | |||
| drawLetters() { | |||
| // Implement this method for wave 1 | |||
| // eslint-disable-next-line max-len | |||
| const letters = ['A', 'A', 'A', 'A', 'A', 'A', 'A', 'A', 'A', 'B', 'B', 'C', 'C', 'D', 'D', 'D', 'D', 'E', 'E', 'E', 'E', 'E', 'E', 'E', 'E', 'E', 'E', 'E', 'E', 'F', 'F', 'G', 'G', 'G', 'H', 'H', 'I', 'I', 'I', 'I', 'I', 'I', 'I', 'I', 'I', 'J', 'K', 'L', 'L', 'L', 'L', 'M', 'M', 'N', 'N', 'N', 'N', 'N', 'N', 'O', 'O', 'O', 'O', 'O', 'O', 'O', 'O', 'P', 'P', 'Q', 'R', 'R', 'R', 'R', 'R', 'R', 'S', 'S', 'S', 'S', 'T', 'T', 'T', 'T', 'T', 'T', 'U', 'U', 'U', 'U', 'V', 'V', 'W', 'W', 'X', 'Y', 'Y', 'Z']; | |||
There was a problem hiding this comment.
This data structure works, but it's not very DRY and would be tricky to change. For example, suppose I said you had the wrong number of "I"s - you would have to do a lot of counting to solve the problem.
Instead you might store a hash of letter frequencies like this
letterQuantities: {
A: 9, B: 2, ...
}
and use it to build a pool of letters dynamically.
| return array; | ||
| }; | ||
|
|
||
| const randomOrder = shuffleLetters(letters) |
There was a problem hiding this comment.
Here, you shuffle the entire array pool of letters... and then, you take the first ten. I think you could refactor this so that you randomly pick ten letters, instead of shuffling the entire array.
|
|
||
| const letters = input.split('') | ||
|
|
||
| letters.forEach(char => { |
There was a problem hiding this comment.
Consider using a loop that allows you to break out so that as soon as you encounter a false you exit the loop.
| }, | ||
|
|
||
| scoreWord(input) { | ||
| const letterPoints = { |
There was a problem hiding this comment.
style note: move this object to ahead of all the functions, but inside the module.
JS Adagrams
Congratulations! You're submitting your assignment!
Comprehension Questions