Leaves - Emily Vomacka #51
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| const letterHand = []; | ||
|
|
||
| letterHandIndices.forEach( function(index) { |
There was a problem hiding this comment.
consider using an arrow function for the anonymous function in the forEach loop
| const letterPool = ('A'.repeat(10) + 'B'.repeat(2) + 'C'.repeat(2) + 'D'.repeat(4) + 'E'.repeat(12) + 'F'.repeat(2) + 'G'.repeat(3) + 'H'.repeat(2) + 'I'.repeat(9) + 'J' + 'K' + 'L'.repeat(4) + 'M'.repeat(2) + 'N'.repeat(6) + 'O'.repeat(8) + 'P'.repeat(2) + 'Q' + 'R'.repeat(6) + 'S'.repeat(4) + 'T'.repeat(6) + 'U'.repeat(4) + 'V'.repeat(2) + 'W'.repeat(2) + 'X' + 'Y'.repeat(2) + 'Z').split(''); | ||
|
|
||
| const letterHandIndices = []; | ||
| do { |
| @@ -1,8 +1,83 @@ | |||
| const Adagrams = { | |||
| drawLetters() { | |||
| // Implement this method for wave 1 | |||
| const letterPool = ('A'.repeat(10) + 'B'.repeat(2) + 'C'.repeat(2) + 'D'.repeat(4) + 'E'.repeat(12) + 'F'.repeat(2) + 'G'.repeat(3) + 'H'.repeat(2) + 'I'.repeat(9) + 'J' + 'K' + 'L'.repeat(4) + 'M'.repeat(2) + 'N'.repeat(6) + 'O'.repeat(8) + 'P'.repeat(2) + 'Q' + 'R'.repeat(6) + 'S'.repeat(4) + 'T'.repeat(6) + 'U'.repeat(4) + 'V'.repeat(2) + 'W'.repeat(2) + 'X' + 'Y'.repeat(2) + 'Z').split(''); | |||
There was a problem hiding this comment.
Style note: Consider giving each letters it's own line.
| const lettersInHandCopy = Array.from(lettersInHand); | ||
| const inputArray = input.split(''); | ||
| let validHand = true | ||
| inputArray.forEach( function(char) { |
There was a problem hiding this comment.
consider refactoring to a different type of loop so that you could return false as soon as it's encountered.
| } | ||
| } | ||
| }); | ||
| if (wordArray.length > 6) { |
| return validHand | ||
| }, | ||
|
|
||
| highestScoreFrom(words) { |
There was a problem hiding this comment.
style note: even though it's not required, placing score(word) above highestScoreFrom(words) is best practice since the later function uses the former.
JS AdagramsWhat We're Looking For
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JS Adagrams
Congratulations! You're submitting your assignment!
Comprehension Questions