Leaves - Natalie & Yitgop

[NatalieTapias]

Rideshare-Rails

Congratulations! You're submitting your assignment! These comprehension questions should be answered by both partners together, not by a single teammate.

Comprehension Questions

Question	Answer
Describe the types of entity relationships you set up in your project and why you set up the relationships that way	A passenger can have many trips. A driver can have many trips. A trip will have one driver and one passenger.
Describe the role of model validations in your application	It allows us to validate input. And also give the user helpful information in the event of any errors.
How did your team break up the work to be done?	We followed functionalities for each model/controller class and split up the work.
What features did you choose to prioritize in your project, and what features, if any, did you have to set aside to meet the deadline?	We chose to prioritize functionalities for all classes and user stories. Testing has been particularly difficult. Styling has not been a priority at all.
What was one thing that your team collectively gained more clarity on after completing this assignment?	Branching in git.
What is your Trello board URL?	https://trello.com/b/xFoubsVv/rideshare-app
What is the Heroku URL of your deployed application?	https://affordable-community-rideshare.herokuapp.com/
What are two discussion points that you and your pair discussed when giving/receiving feedback from each other that you would be willing to share?	-positive mindset has been important to work through difficult problems. -we had a lot of good trust in each others' abilities while working on our parts of the project.

[beccaelenzil]

trip = nil so this creates an error

[beccaelenzil]

Rideshare Rails

What We're Looking For

Feature	Feedback
Baseline
Appropriate git usage with no extraneous files checked in and all team members contributing	check
Answered comprehension questions	check
Uses named routes (like _path)	check
RESTful routes utilized	check
Project Requirements
Table relationships	check
Validation rules for Models	check
Business logic is in the models	check
Tests for validations	check
Tests for relationships	check
Tests for custom model methods	I don't see these.
Tests for controller actions	check -- their are a couple failing tests that I commented on
Database is seeded from the CSV files	check
Trello board is created and utilized in project management	check
Heroku instance is online	check
The app is styled to create an attractive user interface	check -- very user friendly!
Overall	Great job overall. The user experience is very clean. It is clear that the learning goals around model relationships, validations, and seeding were met. There are a couple tests with errors that I've left comments on. It looks like you didn't get to testing your custom model methods, but I suspect the lessons this past week will help with that understanding. Please let me know if you have questions.