Skip to content

Conversation

njch5
Copy link

@njch5 njch5 commented Oct 11, 2019

Rideshare-Rails

Congratulations! You're submitting your assignment! These comprehension questions should be answered by both partners together, not by a single teammate.

Comprehension Questions

Question Answer
Describe the types of entity relationships you set up in your project and why you set up the relationships that way We set the drivers and passengers to have a has_many relationship with trips and trips had a one-to-many (belongs_to) relationship with both drivers and passengers.
Describe the role of model validations in your application We used model validations for the passengers and drivers classes to make sure new or edited instances of the class had required specific fields and to display errors if the user does not fill in the required fields.
How did your team break up the work to be done? We did most of the work together in class and we split up remaining work to do at home. The Trello board was used to direct what work still needed to be done.
What features did you choose to prioritize in your project, and what features, if any, did you have to set aside to meet the deadline? We prioritized building out the CRUD operations, RESTful routes, and basic views for all models/controllers. Afterwards, we were able to implement necessary features like create new trip for a passenger. We de-prioritized styling until the very end.
What was one thing that your team collectively gained more clarity on after completing this assignment? Remote branches/git branching and how to deploy on Heroku.
What is your Trello board URL? https://trello.com/b/Kz5Kdb9h/nicky-and-raisahs-rideshare-app
What is the Heroku URL of your deployed application? https://spooky-ride-share.herokuapp.com/
What are two discussion points that you and your pair discussed when giving/receiving feedback from each other that you would be willing to share? We really enjoyed working together because we both brought different strengths to this project, and we communicated super well on expectations.

raisahv and others added 30 commits October 7, 2019 16:02
…toggle available and toggle unavailable controller methods
@beccaelenzil
Copy link

Rideshare Rails

What We're Looking For

Feature Feedback
Baseline
Appropriate git usage with no extraneous files checked in and all team members contributing check
Answered comprehension questions check
Uses named routes (like _path) check
RESTful routes utilized check
Project Requirements
Table relationships check
Validation rules for Models check
Business logic is in the models check
Tests for validations check
Tests for relationships check
Tests for custom model methods check
Tests for Controller methods check
Database is seeded from the CSV files check
Trello board is created and utilized in project management check
Heroku instance is online check
The app is styled to create an attractive user interface check
Overall Excellent job overall. This code is well-written and well-tested. It is clear to me that the learning goals around model relationships, validations, and seeding were met. Keep up the hard work!

# end

# it "create trip method finds first available driver" do
# Trip.create_new_trip(@passenger.id)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this tested somewhere else?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants