Skip to content

Conversation

jaitch
Copy link

@jaitch jaitch commented Oct 11, 2019

Rideshare-Rails

Congratulations! You're submitting your assignment! These comprehension questions should be answered by both partners together, not by a single teammate.

Comprehension Questions

Question Answer
Describe the types of entity relationships you set up in your project and why you set up the relationships that way Trip belong to Driver and Passenger, Driver has many Trips and Passenger has many Trips. This made sense because it's a one-to-many relationship in that direction.
Describe the role of model validations in your application Driver required 'name' and 'vin'; Passenger required the presence of 'name' and 'phone number'.
How did your team break up the work to be done? At the outset, we set up the project with one partner driving and the other two navigating. Then we split up the three classes (Driver, Passenger, Trips) to set up the structures of those individually. From there, we delegated tasks with Trello and close communication, and checked in regularly.
What features did you choose to prioritize in your project, and what features, if any, did you have to set aside to meet the deadline? We prioritized the functionality of our app over the styling, but, as mentioned below, did have time to focus on style after we got the app fully functioning.
What was one thing that your team collectively gained more clarity on after completing this assignment? How to use the entity relationships to access data among classes.
What is your Trello board URL? https://trello.com/b/YCkqjiss/rideshare
What is the Heroku URL of your deployed application? https://tiffany-bri-janice-ride-share.herokuapp.com
What are two discussion points that you and your pair discussed when giving/receiving feedback from each other that you would be willing to share? We thought our divide-and-conquer strategy was helpful in that it enabled us to accomplish a lot--it would have been hard to finish this project otherwise; we were able to avoid prioritizing certain elements over others, as we would have had to if we'd run out of time. An extended conversation about relationships before setting up the schema also made our subsequent work more efficient than it might have been. We had open communication that invited collaboration within our divide-and-conquer structure. Git was an essential tool in our collaboration.

TiffanyChio and others added 30 commits October 7, 2019 15:55
…thin controller for new, add, edit, update, delete
…hone number, edit and delete functions. Return to passengers option
@beccaelenzil
Copy link

Rideshare Rails

What We're Looking For

Feature Feedback
Baseline
Appropriate git usage with no extraneous files checked in and all team members contributing check
Answered comprehension questions check
Uses named routes (like _path) check
RESTful routes utilized check
Project Requirements
Table relationships check
Validation rules for Models check
Business logic is in the models check
Tests for validations N/A
Tests for relationships check
Tests for custom model methods check
Tests for controller actions check
Database is seeded from the CSV files check
Trello board is created and utilized in project management check
Heroku instance is online check
The app is styled to create an attractive user interface check -- the navigation bar has a bug where add driver and add passenger only appear when you hover over it.
Overall Excellent job overall. This code is well-written and well-tested. It is clear that the learning goals around model relationships, validations, and seeding were met. Keep up the hard work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants