Skip to content

Conversation

sun-alice
Copy link

Rideshare-Rails

Congratulations! You're submitting your assignment! These comprehension questions should be answered by both partners together, not by a single teammate.

Comprehension Questions

Question Answer
Describe the types of entity relationships you set up in your project and why you set up the relationships that way A driver/passenger to trips has a one to many relationship. It was set up so that each driver/passenger can have many trips, and a trip only has one driver and one passenger.
Describe the role of model validations in your application The model validations prevent objects from being created without an essential component. For example, a passenger must a name and phone number in order to be created.
How did your team break up the work to be done? We had one person work on driver and one person work on passenger, and worked on trip things together. This way, we wouldn't be working on the same pieces of code and cause conflicts.
What features did you choose to prioritize in your project, and what features, if any, did you have to set aside to meet the deadline? We prioritized the CRUD of the drivers and passengers, because we needed them in order to continue with trips. We then prioritized the basic trip functions before the smaller features, such as modifying the rating separately from editing the trip. Styling/CSS was left until the end, because that was least important.
What was one thing that your team collectively gained more clarity on after completing this assignment? We gained more clarity on how the many different files in the Rails application interact with each other.
What is your Trello board URL? https://trello.com/b/0v3PW8QK/rideshare-rails
What is the Heroku URL of your deployed application? https://sa-c12-rails-rideshare.herokuapp.com/
What are two discussion points that you and your pair discussed when giving/receiving feedback from each other that you would be willing to share? It was difficult to identify in the beginning which parts each of us could work on separately, so we could maybe discuss that more in the future. We talked a little about how working on a collaborative project that requires individual work makes it very tempting to work on things separately that should have been worked on as a pair. In the future, we should have more communication on things that we want to work on as a pair and individually.

sun-alice and others added 29 commits October 10, 2019 19:14
@beccaelenzil
Copy link

Rideshare Rails

What We're Looking For

Feature Feedback
Baseline
Appropriate git usage with no extraneous files checked in and all team members contributing check
Answered comprehension questions check
Uses named routes (like _path) check
RESTful routes utilized check
Project Requirements
Table relationships check
Validation rules for Models check
Business logic is in the models check
Tests for validations check
Tests for relationships check
Tests for custom model methods check
Tests for controller actions check
Database is seeded from the CSV files check
Trello board is created and utilized in project management check
Heroku instance is online check
The app is styled to create an attractive user interface check
Overall Excellent job overall. This code is well-written and well-tested. It is clear to me that the learning goals around model relationships, validations, and seeding were met. Keep up the hard work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants