Julia - Steph - Branches

[Steph0088]

Rideshare-Rails

Congratulations! You're submitting your assignment! These comprehension questions should be answered by both partners together, not by a single teammate.

Comprehension Questions

Question	Answer
Describe the types of entity relationships you set up in your project and why you set up the relationships that way	We set up our entity relationships so that Trips belong to drivers and passengers. In other words Drivers and Passengers both have many trips. We set them up this way in order to create a trip we will require a passenger and driver. This is how we ensure that the data from each trip will line up a driver id with a passenger id correctly and assign them to the correct trip.
Describe the role of model validations in your application	For a trip to be created it must have a passenger and driver. Driver must have a name and vin and Passenger must have a name and phone number.
How did your team break up the work to be done?	We mostly shared one machine but worked on CSS on separate commits.
What features did you choose to prioritize in your project, and what features, if any, did you have to set aside to meet the deadline?	We chose to prioritize the backend and leave the CSS to the last minute.
What was one thing that your team collectively gained more clarity on after completing this assignment?	Understood the relationship between different models in rails.
What is your Trello board URL?	https://trello.com/b/8MyyClgs/ride-share-rails
What is the Heroku URL of your deployed application?	https://cryptic-bastion-51333.herokuapp.com/
What are two discussion points that you and your pair discussed when giving/receiving feedback from each other that you would be willing to share?	We should have used two machines instead of working on one machine and maybe using branches for features.

[tildeee]

Rideshare Rails

What We're Looking For

Feature	Feedback
Baseline
Appropriate git usage with no extraneous files checked in and all team members contributing	x
Answered comprehension questions	x
Uses named routes (like _path)	x
RESTful routes utilized	x, well done!
Project Requirements
Table relationships	x
Validation rules for Models	x
Business logic is in the models	x
Tests for validations	x
Tests for relationships	x
Tests for custom model methods	x
Tests for controller actions	x
Database is seeded from the CSV files	x
Trello board is created and utilized in project management	x
Heroku instance is online	x
The app is styled to create an attractive user interface	x
Overall

Well done on this project, you two! The app code looks INCREDIBLE, the tests are EXTREMELY well-written and thorough. You all adhered to best practices when it comes to putting logic in the models, strong params, limited nested routes, etc.

You two have one big bug: When deleting a driver or a passenger, if the driver or passenger still has trips associated with them, then your Rails app crashes and gives back a 500 server error. The error message associated is "update or delete on table "drivers" violates foreign key constraint "fk_rails_e7560abc33" on table "trips" DETAIL: Key (id)=(1) is still referenced from table "trips".", meaning that Rails by default doesn't want you all to delete the driver if there's a trip record associated with it...

There are two ways to go from here: Either find a way to delete the data associated with the driver before deleting the driver, or find a way to disconnect the driver from the associated data. Either is valid, though most people tend to delete the trip associated with the driver.

That being said, the code looks great; great work you two! Keep it up!