Leaves - Dianna and Hallie

[dtingg]

Rideshare-Rails

Congratulations! You're submitting your assignment! These comprehension questions should be answered by both partners together, not by a single teammate.

Comprehension Questions

Question	Answer
Describe the types of entity relationships you set up in your project and why you set up the relationships that way	We set up a one-to-many relationship between Drivers and Trips because a driver can have many trips.  We also set up a one-to-many relationship between Passengers and Trips because a passenger can have many trips.
Describe the role of model validations in your application	Model validations help us sanitize the data going into the database.  This helps us prevent harmful side effects like when we try to do calculations and are expecting an integer.  This also ensures that there is data in the fields that are important for our program to run.
How did your team break up the work to be done?	We worked together using traditional pair programming to write code for the controllers, models, and most tests. Then, we split up the front end from the back end.  One person worked on views and CSS styling and the other worked on complex calculations in the model and finished writing our tests.
What features did you choose to prioritize in your project, and what features, if any, did you have to set aside to meet the deadline?	We chose to prioritize functionality over the styling.  However, we did manage to finish a website that we are happy with.
What was one thing that your team collectively gained more clarity on after completing this assignment?	We learned more about working with a database, especially using a foreign key and creating one-to-many relationships.
What is your Trello board URL?	https://trello.com/b/Rejzk6dr/goober-ride-share
What is the Heroku URL of your deployed application?	https://goober-ride-share.herokuapp.com/
What are two discussion points that you and your pair discussed when giving/receiving feedback from each other that you would be willing to share?	1. We discussed how our communication on the project went.  We planned to communicate frequently and openly and we felt like we upheld that goal. 2. We also reviewed how we tackled the various portions of the project.  Overall we are pleased with how we did part of the project together and other parts separately.

[beccaelenzil]

Rideshare Rails

What We're Looking For

Feature	Feedback
Baseline
Appropriate git usage with no extraneous files checked in and all team members contributing	check
Answered comprehension questions	check
Uses named routes (like _path)	check
RESTful routes utilized	check
Project Requirements
Table relationships	check
Validation rules for Models	check
Business logic is in the models	check
Tests for validations	check -- see comment
Tests for relationships	check
Tests for custom model methods	check
Tests for controller actions	check
Database is seeded from the CSV files	check
Trello board is created and utilized in project management	check
Heroku instance is online	check
The app is styled to create an attractive user interface	check -- love the faces!
Overall	Excellent job overall. This code is well-written and well-tested. It is clear that the learning goals around model relationships, validations, and seeding were met. Keep up the hard work!

[beccaelenzil]

This test fails because you changed your message to "Name can't be blank." Consider using something like:

expect(new_driver.errors.messages[:name].downcase).must_include "blank"