Skip to content

Conversation

@canaanwest
Copy link

Ada Trader

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
How do Backbone Views help structure your code? They handle all of the logic that needs to happen between the model and the browser.
Did you use jQuery directly in your Views? How, and why? I didn't. I used it indirectly using this.$ because using jquery directly can impact dom elements outside of the view; using it indirectly prevents this problem.
What was an example of an event you triggered? Why did you need to trigger it? I triggered an append event anytime a trade is purchased from a limit buy/sell order. I used this method because we don't know when the order will actually be executed, but we know that when it is, we want the execution of that trade to be reflected in the "trade history" section. Using the trigger allows us to call this function when that action happens.
In what was is unit testing in JavaScript similar to unit testing in Ruby? In what ways is it different? There are assertions and expectations, as well as describe and it blocks, which make it feel really similar. Slightly different in terms of syntax for setting up tests.

@tildeee
Copy link

tildeee commented Jan 2, 2018

Ada Trader

What We're Looking For

Feature Feedback
Core Requirements
Git hygiene x
Comprehension questions x
Organization
Models and collections are defined in separate files x
Code that relies on the DOM is located in or called by $(document).ready x
Functionality
Quote prices change when clicking Buy and Sell x
The Trade History updates when buying and selling a quote x
A user can create an open order using the Order Entry Form x
An open order removes itself from the open orders and updates the Trade History when fulfilled x
General
Has separate views for different parts of the app x
Uses events (listening/handling and triggering) to manage different behavior in views x
Practices good standards for views (ES6 syntax, doesn't directly use jQuery, returns this in render) x, sometimes you forget your semicolons :)
Error handling for the Order Entry Form x
Testing
Has unit tests for models x
Overall

@tildeee
Copy link

tildeee commented Jan 2, 2018

Overall, good work! Event-driven programming is always interesting, especially in contrast with the message-driven programming we've done otherwise. Keep in mind that event-driven is not the only solution available. Otherwise, great job!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants