Skip to content

Conversation

pmanni02
Copy link

@pmanni02 pmanni02 commented Feb 7, 2018

Calculator

Congratulations! You're submitting your assignment.

Comprehension Questions

Question Answer
Describe how you stored user input in your program? I stored user input in three different variables.
How did you determine what operation to perform? I used a predefined array of accepted operations. Then I used array.include?(input) to check if the user input was in said array.
Do you feel like you used consistent indentation throughout your code? Yes
If you had more time, what would you have added to or changed about the program? I would have attempted optional enhancement of dealing with parentheses.

@pmanni02 pmanni02 changed the title Calculator Hmwk (Ampers: Phoebe) Calculator Hmwk (Ampers - Phoebe) Feb 7, 2018
@tildeee
Copy link

tildeee commented Feb 12, 2018

Calculator

What We're Looking For

Feature Feedback
Takes in two numbers and an operator and performs the mathematical operation. x
Readable code with consistent indentation. x

Great job with the calculator! It's fully functional in all the ways I expect.

I'm surprised you went with if/elsif/elsif conditionals instead of a case statement, but truthfully it all works out and is just as effective :)

I think the code is clean and readable.

Cool use of %w for operation_arr. Great way to check if integer or float.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants