Close Chrome browser through the XBMC remote #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ill kill the Chrome process. This currently causes problems with NetfliXBMC thinking that there are multiple streams already open.
|
Thanks, |
|
I certainly understand. :) LMK if you'd like me to take a look at anything.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch allows the user to close the Chrome browser by pressing "SELECT" on the XBMC remote (web control, lirc, etc.) instead of Alt-F4, CMD-Q, etc. This makes it a bit easier to control your viewing without a full mouse + keyboard setup. I've only tested this on Linux, but it should work equally well on Mac OS X, however Windows will require some additional work since it does not have the UNIX "ps" and "grep" commands and I do not have a Windows test environment. The included stub code might work, but it would kill all Chrome windows, not just the one opened by XBMC. This code is compatible with existing plugins that utilize the Chrome Launcher (i.e., NetfliXBMC and Amazon Chrome Launcher), and will close the Chrome browser on those plugins in the same manner without any additional changes to their code.