[AG-31991] Remove complicated heuristics for $domain modifier #677
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview was deployed to: https://pull-request-677.kb-adg.pages.dev/ |
|
@workingBanana We need to retain info about deprecated behavior, but note that since CoreLibs 1.18 logic is simplified. Examples should mention both cases, though. |
Now that we have the `$to` modifier, `$domain` will no longer match the target domain by default - only when the `$csp` or `$cookie` modifiers are specified. See-also: AG-31991 Signed-off-by: Alexey Zhavoronkov <[email protected]>
workingBanana
force-pushed
the
feature/AG-31991
branch
from
137d503 to
83eaea6
Compare
|
Preview was deployed to: https://pull-request-677.kb-adg.pages.dev/ |
|
Preview was deployed to: https://pull-request-677.kb-adg.pages.dev/ |
sfionov
approved these changes
May 5, 2025
|
Preview was deployed to: https://pull-request-677.kb-adg.pages.dev/ |
|
Preview was deployed to: https://pull-request-677.kb-adg.pages.dev/ |
|
Preview was deployed to: https://pull-request-677.kb-adg.pages.dev/ |
|
|
||
| **Examples** | ||
|
|
||
| - `*$cookie,domain=example.org|example.com` will block cookies for all requests to and from `example.org` and `example.com`. | ||
| - `*$document,domain=example.org|example.com` will block all requests to and from `example.org` and `example.com`. | ||
| - `*$document,domain=example.org|example.com` will block requests only from `example.org` and `example.com` but not to them. |
There was a problem hiding this comment.
Suggested change
| - `*$document,domain=example.org|example.com` will block requests only from `example.org` and `example.com` but not to them. | |
| - `*$document,domain=example.org|example.com` will block requests only from `example.org` and `example.com`, but not to them. |
| - `page$domain=targetdomain.com` will be matched, as it matches the target domain and satisfies all requirements mentioned above. | ||
| - `||*page$domain=targetdomain.com` will not be matched, as the pattern `||*page` may match specific domains, | ||
| e.g. `example.page`. | ||
| - `page$domain=targetdomain.com` will not be matched, as it does not match referrer domain. |
There was a problem hiding this comment.
Suggested change
| - `page$domain=targetdomain.com` will not be matched, as it does not match referrer domain. | |
| - `page$domain=targetdomain.com` will not be matched because it does not match the referrer domain. |
| If some of the conditions above are not met but the rule contains [`$cookie`](#cookie-modifier) or [`$csp`](#csp-modifier) modifier, the target domain will still be matched. | ||
|
|
||
| If the referrer matches a rule with `$domain` that explicitly excludes the referrer domain, then the rule will not be applied even if the target domain also matches the rule. This affects rules with [`$cookie`](#cookie-modifier) and [`$csp`](#csp-modifier) modifiers, too. | ||
| For these modifiers, if the referrer matches a rule with `$domain` that explicitly excludes the referrer domain, then the rule will not be applied even if the target domain also matches the rule. |
There was a problem hiding this comment.
Suggested change
| For these modifiers, if the referrer matches a rule with `$domain` that explicitly excludes the referrer domain, then the rule will not be applied even if the target domain also matches the rule. | |
| These modifiers will not be applied if the referrer matches a rule with `$domain` that explicitly excludes the referrer domain, even if the target domain also matches the rule. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that we have the
$tomodifier,$domainwill no longer match the target domain by default - only when the$cspor$cookiemodifiers are specified.Target CoreLibs version is 1.18