-
Notifications
You must be signed in to change notification settings - Fork 295
Add description of the new $reason modifier #751
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 To request another review, post a new comment with "/windsurf-review".
Preview was deployed to: https://pull-request-751.kb-adg.pages.dev/ |
**Examples** | ||
```adblock | ||
||example.com^$document,reason="Tracker" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
List of predefined localizable tokens should be in KB I think
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are the predefined localizable tokens the same as those listed here uBlockOrigin/uBlock-issues#1195 (comment) ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Discussed offline.
Done, please check
Preview was deployed to: https://pull-request-751.kb-adg.pages.dev/ |
1 similar comment
Preview was deployed to: https://pull-request-751.kb-adg.pages.dev/ |
Relates to: AdguardTeam/CoreLibs#1986