LEM v4

[gcatanese]

In this branch LEM services and models have been updated to support LEM v4.

See our documentation:

• Onboarding v4
• API changes v4 vs v3

Changes

Breaking Changes 🛠

• BusinessLine: remove capability
• SourceOfFunds: remove acquiringBusinessLineId
• SourceOfFunds: make adyenProcessedFunds required

Other Changes 💎

• Individual: add support
• Organization: add support , doingBusinessAsAbsent, registrationNumberAbsent
• SoleProprietorship: add doingBusinessAsAbsent, registrationNumberAbsent
• Trust: add doingBusinessAsAbsent
• UnincorporatedPartnership: add doingBusinessAsAbsent
• ServiceEnum: add new value"issuing"
• SourceOfFunds: add several new attributes (amount, assetMonthsHeld, etc..)
• SourceOfFunds: add array of Financier
• SourceOfFunds. TypeEnum: add several new values ("employment", "donations", etc..)
• TaxInformation: add numberAbsent
• Document: add proofOfDirector

Testing locally

We don't have a Beta version of the library, however you can use the source code of this branch to try out the LEM v4 code.

Clone the repository and access the branch:

git clone https://github.com/Adyen/adyen-node-api-library.git
cd adyen-node-api-library
git checkout lem-v4-generation

Build locally:

npm install
npm run build

In your application package.json update the Adyen dependency (adjust the path accordingly):

{
  "dependencies": {
    "@adyen/api-library": "file:../../adyen-node-api-library"
  }
}

Run your application

npm install
npm run dev

[gemini-code-assist]

Summary of Changes

Hello @gcatanese, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request is a significant update to the Legal Entity Management (LEM) services and models, bringing them in line with LEM v4 of the Adyen API. The changes primarily involve updating API versions and base paths, along with substantial modifications to data models to support new functionalities and improved data capture. This includes refining existing business line definitions, expanding document types, and introducing new entities for financial and support information. The update also broadens the scope of 'Source of Funds' data, allowing for more detailed and varied financial reporting.

Highlights

• API Version Upgrade: The core change involves updating the OpenAPI document version from v3 to v4 across all service and typing files within the legalEntityManagement directory. This includes modifying the API_BASEPATH in service files to reflect the new API version.
• Business Line Model Refinements: The BusinessLine and BusinessLineInfo models have been refined by removing the deprecated capability field and its associated enum. Additionally, the ServiceEnum in these models now includes a new issuing option, expanding the supported business line services.
• Document Type Expansion: The Document model now supports a new document type, proofOfDirector, enhancing the verification capabilities for organizational entities.
• Introduction of New Models: Two new models, Financier and Support, have been introduced. Financier captures details about financial contributors (amount, name, location), while Support provides contact information (email, phone). These new models are integrated into existing structures like Individual and Organization where relevant.
• Enhanced Data Models: Several existing models, including Individual, Organization, SoleProprietorship, SourceOfFunds, TaxInformation, Trust, and UnincorporatedPartnership, have received new fields. Notable additions include doingBusinessAsAbsent and registrationNumberAbsent for various entity types, support for Individual and Organization, and a significant expansion of SourceOfFunds with new types and detailed financial attributes.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request updates the Legal Entity Management (LEM) services and models to support LEM v4. The changes primarily consist of updating the API endpoint versions from v3 to v4 across all relevant service files and modifying the data models to align with the new API specification. This includes removing deprecated fields, adding new ones, and adjusting types. The changes appear to be consistent with a major version upgrade. My review includes a suggestion to improve maintainability by centralizing the duplicated API base path constant.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud