- 
                Notifications
    
You must be signed in to change notification settings  - Fork 254
 
manual sync endo as patches #12065
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Draft
      
      
            mhofman
  wants to merge
  4
  commits into
  master
  
    
      
        
          
  
    
      Choose a base branch
      
     
    
      
        
      
      
        
          
          
        
        
          
            
              
              
              
  
           
        
        
          
            
              
              
           
        
       
     
  
        
          
            
          
            
          
        
       
    
      
from
mhofman/integrate-endo
  
      
      
   
  
    
  
  
  
 
  
      
    base: master
Could not load branches
            
              
  
    Branch not found: {{ refName }}
  
            
                
      Loading
              
            Could not load tags
            
            
              Nothing to show
            
              
  
            
                
      Loading
              
            Are you sure you want to change the base?
            Some commits from the old base branch may be removed from the timeline,
            and old review comments may become outdated.
          
          
                
     Draft
            
            manual sync endo as patches #12065
Conversation
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
    
          Deploying agoric-sdk with  
 | 
    
| Latest commit: | 
d6e789c
 | 
| Status: | ✅ Deploy successful! | 
| Preview URL: | https://8c6bcd74.agoric-sdk.pages.dev | 
| Branch Preview URL: | https://mhofman-integrate-endo.agoric-sdk.pages.dev | 
  This was referenced Oct 7, 2025 
      
d4ca830    to
    377756d      
    Compare
  
    
    
  mhofman 
      added a commit
        to endojs/endo
      that referenced
      this pull request
    
      Oct 8, 2025 
    
    
      
  
    
      
    
  
Refs: Agoric/agoric-sdk#12065 Refs: #2981 #2982 ## Description This adds minimal and functional reproductions for the aliases export failure encountered when attempting to sync endo as patches in agoric-sdk (because endo-branch based integration is busted, see Agoric/agoric-sdk#12068). Add a drive-by test of another failure encountered while writing the repro related to assignment of mutable exported bindings. Asked ChatGPT to generate eslint rules from the learnings of these reproductions to prevent problematic cases, and updated the `@endo/errors` exports accordingly. Rules enabled by default in the recommended set. ### Security Considerations None. ### Scaling Considerations None ### Documentation Considerations None ### Testing Considerations Added failing tests. Integration tested in agoric-sdk: Agoric/agoric-sdk#12065 ### Compatibility Considerations None ### Upgrade Considerations None
    
  mhofman 
      added a commit
        to endojs/endo
      that referenced
      this pull request
    
      Oct 8, 2025 
    
    
      
  
    
      
    
  
Refs: Agoric/agoric-sdk#11454 ## Description Narrows some eventual-send types. In particular, ensure that the result of an eventual call is a promise. Add an `EResult` type which in the future can represent the return type of an eventual send call where remotables are mapped as necessary to their "brand" type only to avoid the caller from relying on what may otherwise look like a local remotable instead of a presence. This mapping is implemented in the `EAwaitedResult` type for explicit usages, but not yet used in the type of `EResult` itself as it breaks too many consumers of `E` that rely on the currently "incorrect" typing. ### Security Considerations None ### Scaling Considerations None ### Documentation Considerations TBD ### Testing Considerations Integration tested in agoric-sdk: Agoric/agoric-sdk#12065 In a perfect world, I'd like to add some type tests of cases I've encountered. ### Compatibility Considerations None ### Upgrade Considerations Type only changes, which we usually don't consider breaking.
    
  mhofman 
      added a commit
        to endojs/endo
      that referenced
      this pull request
    
      Oct 9, 2025 
    
    
      
  
    
      
    
  
Refs: Agoric/agoric-sdk#11454 ## Description Narrows some eventual-send types. In particular, ensure that the result of an eventual call is a promise. Add an `EResult` type which in the future can represent the return type of an eventual send call where remotables are mapped as necessary to their "brand" type only to avoid the caller from relying on what may otherwise look like a local remotable instead of a presence. This mapping is implemented in the `EAwaitedResult` type for explicit usages, but not yet used in the type of `EResult` itself as it breaks too many consumers of `E` that rely on the currently "incorrect" typing. ### Security Considerations None ### Scaling Considerations None ### Documentation Considerations TBD ### Testing Considerations Integration tested in agoric-sdk: Agoric/agoric-sdk#12065 In a perfect world, I'd like to add some type tests of cases I've encountered. ### Compatibility Considerations None ### Upgrade Considerations Type only changes, which we usually don't consider breaking.
    
  mhofman 
      added a commit
        to endojs/endo
      that referenced
      this pull request
    
      Oct 9, 2025 
    
    
      
  
    
      
    
  
Refs: Agoric/agoric-sdk#12065 Refs: #2981 #2982 ## Description This adds minimal and functional reproductions for the aliases export failure encountered when attempting to sync endo as patches in agoric-sdk (because endo-branch based integration is busted, see Agoric/agoric-sdk#12068). Add a drive-by test of another failure encountered while writing the repro related to assignment of mutable exported bindings. Asked ChatGPT to generate eslint rules from the learnings of these reproductions to prevent problematic cases, and updated the `@endo/errors` exports accordingly. Rules enabled by default in the recommended set. ### Security Considerations None. ### Scaling Considerations None ### Documentation Considerations None ### Testing Considerations Added failing tests. Integration tested in agoric-sdk: Agoric/agoric-sdk#12065 ### Compatibility Considerations None ### Upgrade Considerations None
    
  mhofman 
      added a commit
        to endojs/endo
      that referenced
      this pull request
    
      Oct 9, 2025 
    
    
      
  
    
      
    
  
Refs: Agoric/agoric-sdk#11454 ## Description Narrows some eventual-send types. In particular, ensure that the result of an eventual call is a promise. Add an `EResult` type which in the future can represent the return type of an eventual send call where remotables are mapped as necessary to their "brand" type only to avoid the caller from relying on what may otherwise look like a local remotable instead of a presence. This mapping is implemented in the `EAwaitedResult` type for explicit usages, but not yet used in the type of `EResult` itself as it breaks too many consumers of `E` that rely on the currently "incorrect" typing. ### Security Considerations None ### Scaling Considerations None ### Documentation Considerations TBD ### Testing Considerations Integration tested in agoric-sdk: Agoric/agoric-sdk#12065 In a perfect world, I'd like to add some type tests of cases I've encountered. ### Compatibility Considerations None ### Upgrade Considerations Type only changes, which we usually don't consider breaking.
    
  mhofman 
      added a commit
        to endojs/endo
      that referenced
      this pull request
    
      Oct 9, 2025 
    
    
      
  
    
      
    
  
Refs: Agoric/agoric-sdk#12065 Refs: #2981 #2982 ## Description This adds minimal and functional reproductions for the aliases export failure encountered when attempting to sync endo as patches in agoric-sdk (because endo-branch based integration is busted, see Agoric/agoric-sdk#12068). Add a drive-by test of another failure encountered while writing the repro related to assignment of mutable exported bindings. Asked ChatGPT to generate eslint rules from the learnings of these reproductions to prevent problematic cases, and updated the `@endo/errors` exports accordingly. Rules enabled by default in the recommended set. ### Security Considerations None. ### Scaling Considerations None ### Documentation Considerations None ### Testing Considerations Added failing tests. Integration tested in agoric-sdk: Agoric/agoric-sdk#12065 ### Compatibility Considerations None ### Upgrade Considerations None
  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment
  
      
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
Integration test of endojs/endo#2980 and endojs/endo#2849
Patch generated and applied as follow: