Skip to content

Conversation

@gibson042
Copy link
Member

Description

LinkSpec already had a min field, but FlowEdge was missing an analog.

@gibson042 gibson042 requested a review from dtribble October 9, 2025 22:30
@gibson042 gibson042 requested a review from a team as a code owner October 9, 2025 22:30
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Oct 9, 2025

Deploying agoric-sdk with  Cloudflare Pages  Cloudflare Pages

Latest commit: 249072d
Status: ✅  Deploy successful!
Preview URL: https://68e628d1.agoric-sdk.pages.dev
Branch Preview URL: https://gibson-2025-10-ymax-arc-min.agoric-sdk.pages.dev

View logs

if (capacity) throughputConstraint.max = capacity;
throughputConstraints[`through_${id}`] = throughputConstraint;
throughputConstraints[`through_${id}`] = {
min: min || 0,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this be max(min, 0)?

priority?: number; // tie-break hint
enabled?: boolean; // admin toggle
// priority?: number; // tie-break hint
// enabled?: boolean; // admin toggle
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it would be good to have enabled as an honored property so we can suspend a broken route when it's a problem. Not required for this PR

@gibson042 gibson042 added the automerge:rebase Automatically rebase updates, then merge label Oct 10, 2025
Base automatically changed from 11862-use-nfa to master October 10, 2025 16:26
@gibson042 gibson042 force-pushed the gibson-2025-10-ymax-arc-min-flow branch from c047d4c to 249072d Compare October 10, 2025 19:19
@mergify mergify bot merged commit 48249f6 into master Oct 10, 2025
95 checks passed
@mergify mergify bot deleted the gibson-2025-10-ymax-arc-min-flow branch October 10, 2025 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

automerge:rebase Automatically rebase updates, then merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants