Remove deprecation filter #107
Draft
+0
−560
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We remove the filtering of deprecated elements. If an deprecated element should be displayed or not is highly dependent on the implementation and should be decided in the backend or implementation of the data THIS IS A BREAKING CHANGE: deserializePage and deserializePages have been removed If you relied on this module removing deprecated elements from your api response you need to re-implement that custom.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In agreement with @tvdeyen we remove the filtering of deprecated pages and elements and essences in the deserialization. As the
deserializePageandeserializePagesadapter only purpose was to do that they can be removed as welloptimistic on #106