Skip to content

Follow-up for #959: proper spaces, remove nulls order info #1026

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: antalya-25.6.5
Choose a base branch
from
Open

Follow-up for #959: proper spaces, remove nulls order info #1026

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
343d7d6
add spaces
zvonand Sep 18, 2025
634c6da
remove unneeded info
zvonand Sep 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 1 addition & 6 deletions src/Storages/ObjectStorage/DataLakes/Iceberg/IcebergMetadata.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -678,12 +678,7 @@ String composeList(
if (field->has("direction"))
{
auto d = field->getValue<String>("direction");
expr += (Poco::icompare(d, "desc") == 0) ? "DESC" : "ASC";
}
if (field->has("null-order"))
{
auto n = field->getValue<String>("null-order");
expr += (Poco::icompare(n, "nulls-last") == 0) ? "NULLS LAST" : "NULLS FIRST";
expr += (Poco::icompare(d, "desc") == 0) ? " DESC" : " ASC";
}
}

Expand Down
2 changes: 1 addition & 1 deletion tests/integration/test_storage_iceberg/test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3453,7 +3453,7 @@ def test_system_tables_partition_sorting_keys(started_cluster, storage_type):
WHERE name = '{table_name}' FORMAT csv
""").strip().lower()

assert res == '"bucket(16, id), day(ts)","iddescnulls last, hour(ts)ascnulls first"'
assert res == '"bucket(16, id), day(ts)","id desc, hour(ts) asc"'

@pytest.mark.parametrize("storage_type", ["local", "s3"])
def test_compressed_metadata(started_cluster, storage_type):
Expand Down
Loading