Preserve parquet specific parallel formatting for export part #1106
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
maybe it is better to simply store the context ptr? the only question is: can it expire or smth of the sort? |
arthurpassos
changed the title
arthurpassos
commented
Oct 29, 2025
| result += raw_path; | ||
|
|
||
| if (raw_path.back() != '/') | ||
| if (!raw_path.empty() && raw_path.back() != '/') |
Collaborator
Author
There was a problem hiding this comment.
Unrelated but required
Collaborator
Author
|
Not tested yet |
Collaborator
Author
|
Tested with debugger, checked that max_threads, parquet parallel formatting and parallel formatting are kept |
arthurpassos
commented
Oct 29, 2025
| break; | ||
| case Export: | ||
| read_settings.local_throttler = context->getExportsThrottler(); | ||
| addThrottler(read_settings.local_throttler, context->getExportsThrottler()); |
Collaborator
Author
There was a problem hiding this comment.
Merge glitch, only found it now
|
tested and confirm that it works |
Enmk
reviewed
Nov 3, 2025
| bool overwrite_file_if_exists; | ||
| bool parallel_formatting; | ||
| /// parquet has a different setting for parallel formatting | ||
| bool parallel_formatting_parquet; |
Member
There was a problem hiding this comment.
Maybe rename that one to be similar to the setting name? something like
Suggested change
| bool parallel_formatting_parquet; | |
| bool parquet_parallel_encoding; |
Collaborator
Author
|
03572_export_merge_tree_part_to_object_storage - maybe it is flaky, I don't see how this change could break it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Preserve a few file format settings in the export part manifest to be able to better control parallelism
Documentation entry for user-facing changes
...
CI/CD Options
Exclude tests:
Regression jobs to run: