Publish helm charts #1791
Publish helm charts #1791
Conversation
There was a problem hiding this comment.
Do you have access to add new secrets into clickhouse-operator ? did you ask @alex-zaitsev or @sunsingerus about adding it?
If I understood correctly we still publish to https://docs.altinity.com/clickhouse-operator but also publish into https://helm.atlinity.com?
I don't have access to add secrets, I'll reach out and ask. Yes, you're correct, for now this publishes the chart to both locations. |
| @@ -1,5 +1,5 @@ | |||
| apiVersion: v2 | |||
| name: altinity-clickhouse-operator | |||
There was a problem hiding this comment.
I would keep altinity-clickhouse-operator in order to avoid triggering ClickHouse folks.
| @@ -1,5 +1,5 @@ | |||
| apiVersion: v2 | |||
| name: altinity-clickhouse-operator | |||
This makes two significant changes to the operator helm chart release process: - The Operator Chart is now published to *both* docs.altinity.com and helm.altinity.com when new releases are created. (NB: The release name must match the release tag or the release workflow will fail) - The Operator Chart is renamed from `altinity-clickhouse-operator` to `clickhouse-operator` which is cleaner when next to a repo named `altinity`. Because of the way that Chart Releaser works, only *new* releases are merged with the existing helm index.yaml from helm.altinity.com. For the new workflow to work: - An actions variable `HELM_GITHUB_REPOSITORY` must exist and point to the `helm-charts` repository. - An actions secret `HELM_GITHUB_TOKEN` must exist and contain a GitHub PAT with read/write permissions on the `helm-charts` repository. Signed-off-by: Josh Lee <[email protected]>
joshleecreates
force-pushed
the
publish-helm-charts
branch
from
412b1f7 to
98562ee
Compare
| - name: Validate Helm Repository Configuration | ||
| run: | | ||
| if [ -z "${{ secrets.HELM_GITHUB_TOKEN }}" ]; then |
There was a problem hiding this comment.
please, ask @alex-zaitsev annd @sunsingerus to add required secrets to repo
This makes two significant changes to the operator helm chart
release process:
helm.altinity.com when new releases are created. (NB: The release
name must match the release tag or the release workflow will fail)
altinity-clickhouse-operatortoclickhouse-operatorwhich is cleaner when next to a repo namedaltinity.Because of the way that Chart Releaser works, only new releases are
merged with the existing helm index.yaml from helm.altinity.com.
For the new workflow to work:
HELM_GITHUB_REPOSITORYmust exist and point tothe
helm-chartsrepository.HELM_GITHUB_TOKENmust exist and contain a GitHubPAT with read/write permissions on the
helm-chartsrepository.Important items to consider before making a Pull Request
Please check items PR complies to:
next-releasebranch, not intomasterbranch1. More info--
1 If you feel your PR does not affect any Go-code or any testable functionality (for example, PR contains docs only or supplementary materials), PR can be made into
masterbranch, but it has to be confirmed by project's maintainer.