dumpyara.sh: explicitly check the folders generated by fsck.erofs
#51
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There's one case with `fsck.erofs` where it generates folder but fails to extract. The script will now check whether the generated folders are empty or not.
Collaborator
|
Thank you for this PR. For testing purposes, would you be able to share with which image and which firmware this happens? |
Author
|
Collaborator
|
xiaomi.eu is a custom ROM though, is there any stock ROM with split sparse super images? |
Author
|
I understand that xiaomi.eu is a custom ROM and yeah, I've never any OEM do that as per my knowledge. But any OEM may also generate using |
AntoninoScordino
force-pushed
the
master
branch
5 times, most recently
from
c05fd8e to
3a56f23
Compare
AntoninoScordino
force-pushed
the
master
branch
9 times, most recently
from
a3277a7 to
df44f69
Compare
AntoninoScordino
force-pushed
the
master
branch
2 times, most recently
from
f49a0e8 to
3e506e7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's one case with
fsck.erofswhere it generates folder but fails to extract. The script will now check whether the generated folders are empty or not.