Add scripts for app quick build / run #1657
Conversation
|
Why adding this? |
|
Unable to start the app well for all kinds of environment reason when debug (os type, cpu arch, package dependency version, etc...), that's a problem |
There was a problem hiding this comment.
I frankly do not understand the intent of this contribution at all.
This project is a recipe. The entire build process is encapsulated in a single, simple command: docker build . -t cook. All contributors use this method and are expected to solve their own environment-specific issues. Your scripts are a workaround for a problem that only you seem to have.
Imagine the hundreds of Linux distributions in the world, each with a different package manager. It is impossible to guarantee that your script would work perfectly for everyone, in every country. If you cannot commit to something that works universally, you should not be adding it to the repository in the first place. This introduces a massive maintenance burden.
For instance, you've hardcoded Huawei mirrors. How is a developer in the US supposed to build this? You've also introduced a slew of Debian-specific dependencies, for which I see no justification. These are not universal problems.
This is an extremely simple MkDocs project. If you don't know how to build an MkDocs site, that is an issue with MkDocs, not this project. If you find the docker build command too hard to remember, the appropriate solution is a Makefile, which is precisely what that tool is for.
The entire point of Docker is to solve environment discrepancies. Your contribution re-introduces them. This project is so simple that locking down dependencies to this extent is completely unnecessary.
I cannot comprehend the purpose of this pull request. Do not merge this.
注意
Pull Request 提交后，预计 1 分钟内将会得到自动化格式检查的结果。只有通过自动化检查的 Pull Request 才会被人工审核。
签署
必须签署下面的对话框才能开始审核。
HowToCook 仓库采用了 The Unlicense 协议
菜谱在签入前，必须确保其可以直接声明进入 "公共领域"（public domain)。这意味着一旦合并后，任何人都可以自由复制，修改，发布，使用，编译，出售或以菜谱的形式或菜的形式分发，无论是出于商业目的还是非商目的，以及任何手段。