-
-
Notifications
You must be signed in to change notification settings - Fork 4.6k
Fix for #8200: add PLN (Polish Złoty) number format support #8201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
julianengel
wants to merge
1
commit into
AppFlowy-IO:main
Choose a base branch
from
julianengel:feat/add-pln-number-format
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Fix for #8200: add PLN (Polish Złoty) number format support #8201
julianengel
wants to merge
1
commit into
AppFlowy-IO:main
from
julianengel:feat/add-pln-number-format
+7
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add PLN = 37 to NumberFormatPB enum in Rust - Add conversion mappings between NumberFormat::PLN and NumberFormatPB::PLN - Add "Polish złoty" title and "zł" symbol in Flutter UI Note: This requires corresponding NumberFormat::PLN to be added in the collab-database dependency (AppFlowy-Collab repository).
Reviewer's guide (collapsed on small PRs)Reviewer's GuideImplements Polish Złoty support by extending the Rust data model with a new PLN variant and bidirectional enum conversions, and updating the Flutter UI to display the correct PLN label and symbol. File-Level Changes
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for PLN (Polish Złoty) as a number format option in the database fields.
Note: This requires corresponding NumberFormat::PLN to be added in the collab-database dependency (AppFlowy-Collab repository).
Changes needed in collab-database:
In the NumberFormat enum (likely in a file similar to fields/number_type_option.rs), add: PLN = 37,
Feature Preview
This addresses the following issue: #8200
However, a change to
collab-database
is required for it to be a fix.Also, this may need to be adjusted for https://github.com/AppFlowy-IO/AppFlowy-Web
PR Checklist
collab-database
Summary by Sourcery
Add support for the Polish złoty (PLN) number format by extending the Rust NumberFormatPB enum with conversion mappings and updating the Flutter UI with the corresponding label and symbol.
New Features: