Skip to content

Conversation

julianengel
Copy link

@julianengel julianengel commented Aug 29, 2025

This PR adds support for PLN (Polish Złoty) as a number format option in the database fields.

  • Add PLN = 37 to NumberFormatPB enum in Rust
  • Add conversion mappings between NumberFormat::PLN and NumberFormatPB::PLN
  • Add "Polish złoty" title and "zł" symbol in Flutter UI

Note: This requires corresponding NumberFormat::PLN to be added in the collab-database dependency (AppFlowy-Collab repository).

Changes needed in collab-database:

In the NumberFormat enum (likely in a file similar to fields/number_type_option.rs), add: PLN = 37,

Feature Preview

This addresses the following issue: #8200

However, a change to collab-database is required for it to be a fix.

Also, this may need to be adjusted for https://github.com/AppFlowy-IO/AppFlowy-Web

PR Checklist

  • My code adheres to AppFlowy's Conventions
  • I've listed at least one issue that this PR fixes in the description above.
  • I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
  • All existing tests are passing - they will be once it's added to collab-database

Summary by Sourcery

Add support for the Polish złoty (PLN) number format by extending the Rust NumberFormatPB enum with conversion mappings and updating the Flutter UI with the corresponding label and symbol.

New Features:

  • Introduce PLN variant to NumberFormatPB enum and mapping in Rust
  • Display "Polish złoty" title and "zł" symbol for PLN in the Flutter UI

- Add PLN = 37 to NumberFormatPB enum in Rust
- Add conversion mappings between NumberFormat::PLN and NumberFormatPB::PLN
- Add "Polish złoty" title and "zł" symbol in Flutter UI

Note: This requires corresponding NumberFormat::PLN to be added in the
collab-database dependency (AppFlowy-Collab repository).
Copy link
Contributor

sourcery-ai bot commented Aug 29, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Implements Polish Złoty support by extending the Rust data model with a new PLN variant and bidirectional enum conversions, and updating the Flutter UI to display the correct PLN label and symbol.

File-Level Changes

Change Details Files
Add PLN support in Rust data layer
  • Add PLN = 37 variant to NumberFormatPB enum
  • Map NumberFormat::PLN to NumberFormatPB::PLN in From impl
  • Map NumberFormatPB::PLN to NumberFormat::PLN in From impl
frontend/rust-lib/flowy-database2/src/entities/type_option_entities/number_entities.rs
Add PLN label and symbol in Flutter UI
  • Add case returning "Polish złoty" for PLN in title extension
  • Add case returning "zł" for PLN in symbol extension
frontend/appflowy_flutter/lib/plugins/database/application/field/type_option/number_format_bloc.dart

Possibly linked issues


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@CLAassistant
Copy link

CLAassistant commented Aug 29, 2025

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@julianengel julianengel changed the title PR: add PLN (Polish Złoty) number format support Fix for #8200: add PLN (Polish Złoty) number format support Aug 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants